From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AD531C9ED5 for ; Thu, 3 Oct 2024 22:15:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727993702; cv=none; b=c5jbEGQ5cKQfNzN3O4tV0W5T5MZ99CQiY2B1XfL0ojRONAD3oSBXS7jADLOTeIL0E6pHAm3z8kYyfEdbeCjiyDUljjr+Ut+hGsHuUbqNq+uAWgscaKoCAqB7MIhmhsMFg5UIax7PGtbgao6vJGKoS0+Ndng6K+ZWKMRFJYe08Fw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727993702; c=relaxed/simple; bh=Wm+Wae3El+M2ZBDfmungAtoN4HD3tcZ2i9yMZb0+/KU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fDzQUCZRCxiVRLXQFiS6Jet4Gc3HP3q3Nl6byta0u/VJJQarOK3FetLWSRjxFSPy0NPa69kfCvC4Xu9h/Sn/hLhfc5mmYPCOP8KViy6Iol5Ec08g9/p+/pJIiR+dESnPwl9WHIx9TtZwvRWGZvIz4tLx2xAV2s6YSbZusWHfP5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=mIs8mcBp; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="mIs8mcBp" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20bcae5e482so14011465ad.0 for ; Thu, 03 Oct 2024 15:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1727993700; x=1728598500; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aKcx4mSd/6y//cnPDUFf8gQTgd9+fKKEcuxJUXsGmAw=; b=mIs8mcBphetNFfGBEfNbGt5ObYLiOfju7CK1HKn14KeoEu1Y9attuasXJnUY/Lz404 GvzGWQTqTxo3Mx8BSz/8mTLaSW6jCN2IvYBF4mZ6R9K6QSzKYwpVpFKYCgIN9lOZHvr0 CgkMWBQyChgdJMQtqER9+ZGLunidUArn+Lmel6j02zh47zKccsihRxclOaYXsNJaQj12 I2qDB8RCdO7yHCzc4jxIOTqFXcDmnNmtqJhxcrgbZSkppJoA/ygUGBe5SVTn9boL1sEZ AsYm5UNv9MYsZrf1SDBuFHTJkVfjtloSvmSgkzrsHlUK3xBUjxCNA/XrVF6toQsbVjG+ 72Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727993700; x=1728598500; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aKcx4mSd/6y//cnPDUFf8gQTgd9+fKKEcuxJUXsGmAw=; b=bMVEWIzVsO4lC+Encs+q8/manxnxIuXD2FBYF/Bifwj2DCusWc0EFICy5JsE/RaRIX 37ZMVO5Ai4JQLiKrOoWwGm/d0KFCCGNx3vgFBnf637/ajHwGYVi3CVk3GWdW2E98wpld VsP5RZgqBsL5FPMIWBhFW7bkRBvwhJHirjmkgRZzxGvm9ZKB/pgLywpLIUAEQcmT4sF+ D/ORU0drDGQtoaBhHGp/KJ5Sz10zPlB02lDaTKwjdxvkk32DL92uA2dtUTP1ZSTaNJRM lnW6pubO/SCT9dkQ8s1uvgpnv892Fvci8NlyEBNYK817YmpNCGgelc+KHwmrV4+U2d9I ZjNg== X-Forwarded-Encrypted: i=1; AJvYcCXJ5nNvONQVIwucNG+M9IoM2Nr6VevJic/6HF+yaWTjIMxeQD/DyckyQiyF4d/wPHqEuxKh+ij5Vw==@vger.kernel.org X-Gm-Message-State: AOJu0YxKnizRzBWuXpBh1YFFhfCm1b/blzMBXCT9ktp88GY41QtfFLfU 0Iblyvz9gU20YPhTCBvv2/NQA9AMURqbkVCdCYqgr/gR/a5UT+feAbs/zEZ0o6s= X-Google-Smtp-Source: AGHT+IEa8OibXU8u5AU9dURn3INaVlJRzRZ2R5VooIMzXfRbVR8kevOP6FlKzcqQxHqYef2QRhpO7w== X-Received: by 2002:a17:90b:224e:b0:2e0:8719:5f00 with SMTP id 98e67ed59e1d1-2e1e62a93f6mr663348a91.22.1727993700011; Thu, 03 Oct 2024 15:15:00 -0700 (PDT) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e1e8643534sm8913a91.50.2024.10.03.15.14.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 15:14:59 -0700 (PDT) Message-ID: Date: Thu, 3 Oct 2024 16:14:57 -0600 Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 0/3] FDP and per-io hints To: Christoph Hellwig , "Martin K. Petersen" Cc: Keith Busch , Kanchan Joshi , hare@suse.de, sagi@grimberg.me, brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jaegeuk@kernel.org, bcrl@kvack.org, dhowells@redhat.com, bvanassche@acm.org, asml.silence@gmail.com, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, gost.dev@samsung.com, vishak.g@samsung.com, javier.gonz@samsung.com References: <20240930181305.17286-1-joshi.k@samsung.com> <20241001092047.GA23730@lst.de> <99c95f26-d6fb-4354-822d-eac94fdba765@kernel.dk> <20241002075140.GB20819@lst.de> <20241002151344.GA20364@lst.de> <20241002151949.GA20877@lst.de> <20241003125400.GB17031@lst.de> Content-Language: en-US From: Jens Axboe In-Reply-To: <20241003125400.GB17031@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/3/24 6:54 AM, Christoph Hellwig wrote: > For file: yes. The problem is when you have more files than buckets on > the device or file systems. Typical enterprise SSDs support somewhere > between 8 and 16 write streams, and there typically is more data than > that. So trying to group it somehow is good idea as not all files can > have their own bucket. > > Allowing this inside a file like done in this patch set on the other > hand is pretty crazy. I do agree that per-file hints are not ideal. In the spirit of making some progress, how about we just retain per-io hints initially? We can certainly make that work over dio. Yes buffered IO won't work initially, but at least we're getting somewhere. -- Jens Axboe