From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Subject: Re: [PATCH liburing v5 2/2] test/splice: add basic splice tests
Date: Mon, 24 Feb 2020 21:47:49 +0300 [thread overview]
Message-ID: <c863a99f-aa29-4629-a959-53c584f4d2ed@gmail.com> (raw)
In-Reply-To: <89272517-d4c4-1a0f-f955-af2b1c1a337f@kernel.dk>
[-- Attachment #1.1: Type: text/plain, Size: 842 bytes --]
On 24/02/2020 21:41, Jens Axboe wrote:
>> I've wanted for long to kill this weird behaviour, it should consume the whole
>> link. Can't imagine any userspace app handling all edge-case errors right...
>
> Yeah, for links it makes sense to error the chain, which would consume
> the whole chain too.
>
>>> submit fails. I'll clean up that bit.
>>
>> ...I should have tested better. Thanks!
>
> No worries, just trying to do better than we have in the best so we can
> have some vague hope of having the test suite pass on older stable
> kernels.
Have you gave a thought to using C++ for testing? It would be really nice to
have some flexible test generator removing boilerplate and allowing
automatically try different flags combinations. It sounds like a lot of pain
doing this in old plain C.
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-02-24 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 17:54 [PATCH v5 0/2] splice helpers + tests Pavel Begunkov
2020-02-24 17:55 ` [PATCH liburing v5 1/2] splice: add splice(2) helpers Pavel Begunkov
2020-02-24 17:55 ` [PATCH liburing v5 2/2] test/splice: add basic splice tests Pavel Begunkov
2020-02-24 18:23 ` Jens Axboe
2020-02-24 18:26 ` Pavel Begunkov
2020-02-24 18:33 ` Jens Axboe
2020-02-24 18:39 ` Pavel Begunkov
2020-02-24 18:41 ` Jens Axboe
2020-02-24 18:47 ` Pavel Begunkov [this message]
2020-02-24 19:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c863a99f-aa29-4629-a959-53c584f4d2ed@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox