From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ispras.ru (mail.ispras.ru [83.149.199.84]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B27762C182; Sat, 6 Apr 2024 11:12:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.149.199.84 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712401942; cv=none; b=mc9NpyT9QhklRg4h8yR4d1Ylc5P+AZCRZzkU7Gd9vQSwmrTYR7a88mHlEN+nyl9TiniF3X0hQQQLEhN91OO3cY9VTovWxMfj1SVqbSDqfrgHrF3v9rqzD3T6aCjlKoH+BBDqUb2zU6l41DrbwHpjIvm6NH8B9f7scYdJM0DkYDk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712401942; c=relaxed/simple; bh=/Na42PaebErLTeUeIhSCBAG010sjkEo4nu6zNSWufjo=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=gM2st2gEK8thPn0c9hl1RfK8A+c7fq3ODiOUTlBP7M0L6nb9FyD1oyzy4yAenJ02ymotllXK1Gi9UNY3MB97amYNtsVc6Uosr2FO1gQNb/FA44P9jS0jplTBHGK75MlHg/z0TuuKUaqUbHl0IFEs4TOCevNzLOLhn3QzC6u9CJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru; spf=pass smtp.mailfrom=ispras.ru; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b=Rrsz1hBG; arc=none smtp.client-ip=83.149.199.84 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ispras.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ispras.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ispras.ru header.i=@ispras.ru header.b="Rrsz1hBG" Received: from mail.ispras.ru (unknown [83.149.199.84]) by mail.ispras.ru (Postfix) with ESMTPSA id D3F2740762DC; Sat, 6 Apr 2024 11:12:15 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.ispras.ru D3F2740762DC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ispras.ru; s=default; t=1712401935; bh=6wci41eDzOFmYi6xp+siMj+Kcr1MZCDRbXEFul7wU0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Rrsz1hBGN6GVTvOyUZEqiDZDuxT3KigQLq8ra24Nv9F7SGP9jGQ8Sj/75ohJ2bg0T AUS60CW5/zFjLtKEbGmCvkG82SGWh7MLvYOR6fokRnu6GcgxCm4lRYJYteG7/7Hk2X xcJpCGtDXp07N9xgUexQmCqcEpWSOCaBIbxJKdoM= Precedence: bulk X-Mailing-List: io-uring@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Sat, 06 Apr 2024 14:12:15 +0300 From: Alexey Izbyshev To: Jens Axboe Cc: Pavel Begunkov , Olivier Langlois , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] io_uring: Fix io_cqring_wait() not restoring sigmask on get_timespec64() failure In-Reply-To: References: <20240405125551.237142-1-izbyshev@ispras.ru> User-Agent: Roundcube Webmail/1.4.13 Message-ID: X-Sender: izbyshev@ispras.ru Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 2024-04-06 05:06, Jens Axboe wrote: > On 4/5/24 6:55 AM, Alexey Izbyshev wrote: >> This bug was introduced in commit 950e79dd7313 ("io_uring: minor >> io_cqring_wait() optimization"), which was made in preparation for >> adc8682ec690 ("io_uring: Add support for napi_busy_poll"). The latter >> got reverted in cb3182167325 ("Revert "io_uring: Add support for >> napi_busy_poll""), so simply undo the former as well. > > Thanks - ironically I had to hand apply this one, as some of the > commits you mention above are not in the base you used for the > patch... I used v6.8 as the base, and all three commits mentioned above are there. However, the patch indeed doesn't apply to the current tip because of post-v6.8 changes, sorry for that! Thanks, Alexey