Linux io-uring development
 help / color / mirror / Atom feed
From: lizetao <lizetao1@huawei.com>
To: Caleb Sander Mateos <csander@purestorage.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	Pavel Begunkov <asml.silence@gmail.com>,
	"io-uring@vger.kernel.org" <io-uring@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] io_uring/rsrc: remove unused constants
Date: Wed, 19 Feb 2025 06:25:04 +0000	[thread overview]
Message-ID: <d00aa2f3083b48189667355d938089ec@huawei.com> (raw)
In-Reply-To: <20250219033444.2020136-1-csander@purestorage.com>

Hi,

> -----Original Message-----
> From: Caleb Sander Mateos <csander@purestorage.com>
> Sent: Wednesday, February 19, 2025 11:35 AM
> To: Jens Axboe <axboe@kernel.dk>; Pavel Begunkov <asml.silence@gmail.com>
> Cc: Caleb Sander Mateos <csander@purestorage.com>; io-
> uring@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] io_uring/rsrc: remove unused constants
> 
> IO_NODE_ALLOC_CACHE_MAX has been unused since commit fbbb8e991d86
> ("io_uring/rsrc: get rid of io_rsrc_node allocation cache") removed the
> rsrc_node_cache.
> 
> IO_RSRC_TAG_TABLE_SHIFT and IO_RSRC_TAG_TABLE_MASK have been
> unused since commit 7029acd8a950 ("io_uring/rsrc: get rid of per-ring
> io_rsrc_node list") removed the separate tag table for registered nodes.
> 
> Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
> ---
>  io_uring/rsrc.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/io_uring/rsrc.h b/io_uring/rsrc.h index
> a6d883c62b22..0297daf02ac7 100644
> --- a/io_uring/rsrc.h
> +++ b/io_uring/rsrc.h
> @@ -2,16 +2,10 @@
>  #ifndef IOU_RSRC_H
>  #define IOU_RSRC_H
> 
>  #include <linux/lockdep.h>
> 
> -#define IO_NODE_ALLOC_CACHE_MAX 32
> -
> -#define IO_RSRC_TAG_TABLE_SHIFT	(PAGE_SHIFT - 3)
> -#define IO_RSRC_TAG_TABLE_MAX	(1U << IO_RSRC_TAG_TABLE_SHIFT)
> -#define IO_RSRC_TAG_TABLE_MASK	(IO_RSRC_TAG_TABLE_MAX - 1)
> -
>  enum {
>  	IORING_RSRC_FILE		= 0,
>  	IORING_RSRC_BUFFER		= 1,
>  };
> 
> --
> 2.45.2
> 

Reviewed-by: Li Zetao <lizetao1@huawei.com>

---
Li Zetao


  reply	other threads:[~2025-02-19  6:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19  3:34 [PATCH] io_uring/rsrc: remove unused constants Caleb Sander Mateos
2025-02-19  6:25 ` lizetao [this message]
2025-02-19 15:06 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d00aa2f3083b48189667355d938089ec@huawei.com \
    --to=lizetao1@huawei.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox