From: Jens Axboe <axboe@kernel.dk>
To: Breno Leitao <leitao@debian.org>,
Pavel Begunkov <asml.silence@gmail.com>
Cc: christophe.jaillet@wanadoo.fr,
"open list:IO_URING" <io-uring@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] io_uring/io-wq: Use set_bit() and test_bit() at worker->flags
Date: Tue, 7 May 2024 09:09:30 -0600 [thread overview]
Message-ID: <d7d87db7-af34-4d48-8e26-ac13b5abced9@kernel.dk> (raw)
In-Reply-To: <20240507150506.1748059-1-leitao@debian.org>
On 5/7/24 9:05 AM, Breno Leitao wrote:
> @@ -631,7 +631,7 @@ static int io_wq_worker(void *data)
> bool exit_mask = false, last_timeout = false;
> char buf[TASK_COMM_LEN];
>
> - worker->flags |= (IO_WORKER_F_UP | IO_WORKER_F_RUNNING);
> + set_mask_bits(&worker->flags, 0, IO_WORKER_F_UP | IO_WORKER_F_RUNNING);
This takes a mask, no? I think this should be:
set_mask_bits(&worker->flags, 0, BIT(IO_WORKER_F_UP) | BIT(IO_WORKER_F_RUNNING);
Hmm?
--
Jens Axboe
next prev parent reply other threads:[~2024-05-07 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-07 15:05 [PATCH v2] io_uring/io-wq: Use set_bit() and test_bit() at worker->flags Breno Leitao
2024-05-07 15:09 ` Jens Axboe [this message]
2024-05-07 16:34 ` Christophe JAILLET
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7d87db7-af34-4d48-8e26-ac13b5abced9@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=io-uring@vger.kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox