Re: [bug report] io_uring/zcrx: add support for multiple ifqs

[Pavel Begunkov <asml.silence@gmail.com>]

On 4/23/25 14:14, Jens Axboe wrote:
> On 4/23/25 4:30 AM, Pavel Begunkov wrote:
>> On 4/23/25 11:04, Pavel Begunkov wrote:
>>> On 4/23/25 08:15, Dan Carpenter wrote:
>>>> Hello Pavel Begunkov,
>>>>
>>>> Commit 9c2a1c508442 ("io_uring/zcrx: add support for multiple ifqs")
>>>> from Apr 20, 2025 (linux-next), leads to the following Smatch static
>>>> checker warning:
>>>>
>>>>      io_uring/zcrx.c:457 io_register_zcrx_ifq()
>>>>      error: uninitialized symbol 'id'.
>>>>
>>>> io_uring/zcrx.c
>>> ...
>>>>       396         ifq = io_zcrx_ifq_alloc(ctx);
>>>>       397         if (!ifq)
>>>>       398                 return -ENOMEM;
>>>>       399
>>>>       400         scoped_guard(mutex, &ctx->mmap_lock) {
>>>>       401                 /* preallocate id */
>>>>       402                 ret = xa_alloc(&ctx->zcrx_ctxs, &id, NULL, xa_limit_31b, GFP_KERNEL);
>>>>       403                 if (ret)
>>>>       404                         goto err;
>>>>
>>>> Potentially uninitialized on this path.  Presumably we don't need to
>>>> erase id if alloc fails.
>>>
>>> Thanks for letting know
>>
>> Jens, do you want a separate patch or to fix it up as it's the top
>> patch? This should do
> 
> I can just fold it in - done!

Great, thanks!

-- 
Pavel Begunkov