Re: [PATCH for-next 01/12] io_uring: infrastructure for retargeting rsrc nodes

Jens Axboe
2022-10-31T16:02:42Z

On 10/31/22 7:41 AM, Dylan Yudaken wrote:
> +static void io_rsrc_retarget_schedule(struct io_ring_ctx *ctx)
> + __must_hold(&ctx->uring_lock)
> +{
> + percpu_ref_get(&ctx->refs);
> + mod_delayed_work(system_wq, &ctx->rsrc_retarget_work, 60 * HZ);
> + ctx->rsrc_retarget_scheduled = true;
> +}

Can this ever be called with rsrc_retarget_work already pending? If so,
that would seem to leak a ctx ref.

--
Jens Axboe