From: Jens Axboe <axboe@kernel.dk>
To: Pavel Begunkov <asml.silence@gmail.com>,
Bijan Mottahedeh <bijan.mottahedeh@oracle.com>
Cc: io-uring@vger.kernel.org
Subject: Re: [RFC 1/1] io_uring: use valid mm in io_req_work_grab_env() in SQPOLL mode
Date: Sat, 20 Jun 2020 08:22:14 -0600 [thread overview]
Message-ID: <e6178e2d-8fa7-4837-a2c1-b167179177dc@kernel.dk> (raw)
In-Reply-To: <a812d57b-7d95-8844-4c50-9155aca0884d@gmail.com>
On 6/20/20 3:59 AM, Pavel Begunkov wrote:
> On 20/06/2020 02:57, Bijan Mottahedeh wrote:
>> If current->mm is not set in SQPOLL mode, then use ctx->sqo_mm;
>> otherwise fail thre request.
>
> io_sq_thread_acquire_mm() called from io_async_buf_retry() should've
> guaranteed presence of current->mm. Though, the problem could be in
> "io_op_defs[req->opcode].needs_mm" check there, which is done only
> for the first request in a link.
Right, Bijan are you sure this isn't fixed by one of the fixes that
went upstream yesterday:
commit 9d8426a09195e2dcf2aa249de2aaadd792d491c7
Author: Jens Axboe <axboe@kernel.dk>
Date: Tue Jun 16 18:42:49 2020 -0600
io_uring: acquire 'mm' for task_work for SQPOLL
--
Jens Axboe
next prev parent reply other threads:[~2020-06-20 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 23:57 [RFC 0/1] io_uring: use valid mm in io_req_work_grab_env() in SQPOLL mode Bijan Mottahedeh
2020-06-19 23:57 ` [RFC 1/1] " Bijan Mottahedeh
2020-06-20 9:59 ` Pavel Begunkov
2020-06-20 14:22 ` Jens Axboe [this message]
2020-06-22 20:48 ` Bijan Mottahedeh
2020-06-20 22:23 ` [RFC 0/1] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e6178e2d-8fa7-4837-a2c1-b167179177dc@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=bijan.mottahedeh@oracle.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox