From: Pavel Begunkov <asml.silence@gmail.com>
To: Bob Liu <bob.liu@oracle.com>, axboe@kernel.dk
Cc: io-uring@vger.kernel.org
Subject: Re: [PATCH] io_uring: fix duplicated increase of cached_cq_overflow
Date: Fri, 15 Nov 2019 19:35:49 +0300 [thread overview]
Message-ID: <e7fe841d-6103-b6e8-a37b-9a368ad801c5@gmail.com> (raw)
In-Reply-To: <e09c3cb3-1368-1e77-6207-78487b31ffe1@oracle.com>
[-- Attachment #1.1: Type: text/plain, Size: 563 bytes --]
On 15/11/2019 16:10, Bob Liu wrote:
>>> io_cqring_overflow_flush(force=true) must have been called when this branch is executed,
>>> since io_cqring_overflow_flush() is the only place can set 'ctx->cq_overflow_flushed' to true.
>>>
>> Yes, it should have been called, but it sets this flag for the future
>> users of io_cqring_fill_event(), so any _new_ requests in
>> io_cqring_fill_event() will overflow instead of being added to
>> @overflow_list.
>>
>
> Oh, I see..Thanks for the kindly explanation.
>
Sure, no problem
--
Pavel Begunkov
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-11-15 16:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 9:37 [PATCH] io_uring: fix duplicated increase of cached_cq_overflow Bob Liu
2019-11-15 9:49 ` Pavel Begunkov
2019-11-15 12:17 ` Bob Liu
2019-11-15 12:41 ` Pavel Begunkov
2019-11-15 13:10 ` Bob Liu
2019-11-15 16:35 ` Pavel Begunkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7fe841d-6103-b6e8-a37b-9a368ad801c5@gmail.com \
--to=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=bob.liu@oracle.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox