Linux io-uring development
 help / color / mirror / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Jens Axboe <axboe@kernel.dk>, io-uring@vger.kernel.org
Subject: Re: [PATCH liburing] examples/zcrx: don't forget to sync dmabuf
Date: Sun, 18 Oct 2026 23:30:13 +0100	[thread overview]
Message-ID: <f1cece19-31e9-47a4-a25b-839192660674@gmail.com> (raw)
In-Reply-To: <d9f0cfe4-d728-4f70-95de-b3e50e522019@kernel.dk>

On 10/16/26 17:57, Jens Axboe wrote:
> On 10/16/26 10:47 AM, Pavel Begunkov wrote:
>> On 10/16/26 17:38, Jens Axboe wrote:
>>> On 10/16/26 10:36 AM, Pavel Begunkov wrote:
>>>> On 10/16/26 17:29, Jens Axboe wrote:
>>>>> On 10/16/26 10:25 AM, Pavel Begunkov wrote:
>>>>>> dma-bufs are not always coherent and we need to sync it before
>>>>>> accessing. Use proper dma-buf API for that.
>>>>>
>>>>> Can we get a Fixes tag for this please? Other fixes from today
>>>>> lacked that as well, please always add fixes tags.
>>>>
>>>> There was no "fixes" today.
>>>
>>> Sure let's argue that, I merged 4 fixes from you this morning. None of
>>> them had Fixes tags.
>>
>> There is nothing to argue about, I doubt anyone would call a
>> tabulation change or adding a kerneldoc "a fix".
> 
> But we're talking about it, now another round... And justifying it. The
> way I see it, anything that fixes something in a previous patch is, by
> definition, a fix for that patch and should be labeled as such. That's
> usually not something that people question. It doesn't need to fix
> something that's functionally broken to be labeled a fix. For the
> latter, if it's broken in a user visible way, we'd add stable to that
> patch as well. Or just send it manually too, if it's missing from the
> patch. That's the definition I use as the maintainer of those areas, and
> that's why I ask for them.

Jens, thank you for the insight. It was confusing because the public
documentation refer to bugs, but since you use it differently, I'll make
sure all patches that correct typos and indentation, add new docs,
introduce new APIs and extending existing ones, or do other enhancements
have a "Fixes" tag for you as the maintainer of those areas.

-- 
Pavel Begunkov


  reply	other threads:[~2026-10-18 22:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 16:25 [PATCH liburing] examples/zcrx: don't forget to sync dmabuf Pavel Begunkov
2026-10-16 16:29 ` Jens Axboe
2026-10-16 16:36   ` Pavel Begunkov
2026-10-16 16:38     ` Jens Axboe
2026-10-16 16:47       ` Pavel Begunkov
2026-10-16 16:57         ` Jens Axboe
2026-10-18 22:30           ` Pavel Begunkov [this message]
2026-10-16 16:39 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f1cece19-31e9-47a4-a25b-839192660674@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=io-uring@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox