From: Jens Axboe <axboe@kernel.dk>
To: Ammar Faizi <ammarfaizi2@gnuweeb.org>, Dylan Yudaken <dylany@meta.com>
Cc: Pavel Begunkov <asml.silence@gmail.com>,
GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
io-uring Mailing List <io-uring@vger.kernel.org>,
Facebook Kernel Team <kernel-team@fb.com>,
Dylan Yudaken <dylany@fb.com>
Subject: Re: [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang
Date: Thu, 20 Oct 2022 05:52:08 -0700 [thread overview]
Message-ID: <f905c8cb-702f-6b2c-8954-1a736feb1ee7@kernel.dk> (raw)
In-Reply-To: <0e72af49-9e6c-2cc2-c53c-3966b20517cf@gnuweeb.org>
On 10/20/22 5:12 AM, Ammar Faizi wrote:
> On 10/20/22 6:52 PM, Ammar Faizi wrote:
>> From: Dylan Yudaken<dylany@fb.com>
>>
>> liburing has a couple of int shortening issues found by clang. Clean
>> them all. This cleanup is particularly useful for build systems that
>> include these files and run with that error enabled.
>>
>> Link:https://lore.kernel.org/io-uring/20221019145042.446477-1-dylany@meta.com
>> Signed-off-by: Dylan Yudaken<dylany@fb.com>
>> Co-authored-by: Ammar Faizi<ammarfaizi2@gnuweeb.org>
>> Signed-off-by: Ammar Faizi<ammarfaizi2@gnuweeb.org>
>
> BTW, before it's too late. I think we should be consistent on the cast
> style:
>
> (type) a
>
> or
>
> (type)a
>
> What do you think?
I tend to prefer (type) a, but sometimes if you have multiple casts
or the lines become too long, I'll do (type)a. I don't think it's
super important in terms of style, as it isn't that prevalent.
--
Jens Axboe
next prev parent reply other threads:[~2022-10-20 12:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 11:52 [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings Ammar Faizi
2022-10-20 11:52 ` [PATCH liburing v1 1/3] liburing: Clean up `-Wshorten-64-to-32` warnings from clang Ammar Faizi
2022-10-20 12:12 ` Ammar Faizi
2022-10-20 12:52 ` Jens Axboe [this message]
2022-10-20 11:52 ` [PATCH liburing v1 2/3] Makefile: Introduce `LIBURING_CFLAGS` variable Ammar Faizi
2022-10-20 11:52 ` [PATCH liburing v1 3/3] github: Append `-Wshorten-64-to-32` flag for clang build Ammar Faizi
2022-10-20 12:53 ` [PATCH liburing v1 0/3] Clean up clang `-Wshorten-64-to-32` warnings Dylan Yudaken
2022-10-20 12:57 ` Ammar Faizi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f905c8cb-702f-6b2c-8954-1a736feb1ee7@kernel.dk \
--to=axboe@kernel.dk \
--cc=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=dylany@fb.com \
--cc=dylany@meta.com \
--cc=gwml@vger.gnuweeb.org \
--cc=io-uring@vger.kernel.org \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).