From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH] handshake: don't print NULL pmksa pointer
Date: Mon, 6 Jan 2025 09:27:27 -0600 [thread overview]
Message-ID: <092b1528-96d8-4995-99b5-efde7883cde1@gmail.com> (raw)
In-Reply-To: <759fcc78-4ea7-4d74-8ee8-dc2704f3fed5@gmail.com>
Hi James,
>>
>> Why is this behavior undefined? Would it not just print 0x0000...?
>
> I had a brain fart, I was thinking for some reason it was using %s not %p. So
> yes, this is a valid input to the %p formatter.
>
> I can alter the commit description, but I do think it still makes sense to move
> the print, or at least modify it to make it clear no PMKSA was cached, rather
> than just printing "nul" or "nil" or "0x0000".
Sure, that makes sense.
Regards,
-Denis
prev parent reply other threads:[~2025-01-06 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-06 13:46 [PATCH] handshake: don't print NULL pmksa pointer James Prestwood
2025-01-06 15:14 ` Denis Kenzior
2025-01-06 15:26 ` James Prestwood
2025-01-06 15:27 ` Denis Kenzior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=092b1528-96d8-4995-99b5-efde7883cde1@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
--cc=prestwoj@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox