From: Denis Kenzior <denkenz at gmail.com>
To: iwd at lists.01.org
Subject: Re: [PATCH 06/12] frame-xchg: set allow multicast flag
Date: Thu, 20 Jan 2022 14:17:13 -0600 [thread overview]
Message-ID: <0ad74b26-9ea4-d703-7026-fb4eb6ef9ecc@gmail.com> (raw)
In-Reply-To: 20220118212512.2017977-6-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 890 bytes --]
Hi James,
On 1/18/22 15:25, James Prestwood wrote:
> Receiving multicast frames is required by DPP
> ---
> src/frame-xchg.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/frame-xchg.c b/src/frame-xchg.c
> index 5ba36081..95c030d8 100644
> --- a/src/frame-xchg.c
> +++ b/src/frame-xchg.c
> @@ -611,6 +611,7 @@ bool frame_watch_add(uint64_t wdev_id, uint32_t group_id, uint16_t frame_type,
>
> l_genl_msg_append_attr(msg, NL80211_ATTR_WDEV, 8, &wdev_id);
> l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_TYPE, 2, &frame_type);
> + l_genl_msg_append_attr(msg, NL80211_ATTR_RECEIVE_MULTICAST, 0, NULL);
Should this be opt-in? You may want to audit all uses of frame_watch_add to see
if they can deal with multicast frames.
> l_genl_msg_append_attr(msg, NL80211_ATTR_FRAME_MATCH,
> prefix_len, prefix);
>
>
Regards,
-Denis
next reply other threads:[~2022-01-20 20:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 20:17 Denis Kenzior [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-20 23:14 [PATCH 06/12] frame-xchg: set allow multicast flag James Prestwood
2022-01-18 21:25 James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ad74b26-9ea4-d703-7026-fb4eb6ef9ecc@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox