Re: [PATCH 4/4] unit: add unit test for DPP crypto operations

[Denis Kenzior <denkenz at gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1464 bytes --]

Hi James,

On 12/6/21 3:03 PM, James Prestwood wrote:
> ---
>   Makefile.am     |   7 ++-
>   unit/test-dpp.c | 147 ++++++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 153 insertions(+), 1 deletion(-)
>   create mode 100644 unit/test-dpp.c
> 

<snip>

> @@ -547,6 +548,10 @@ unit_test_p2p_SOURCES = unit/test-p2p.c src/wscutil.h src/wscutil.c \
>   				src/band.h src/band.c
>   unit_test_p2p_LDADD = $(ell_ldadd)
>   
> +unit_test_dpp_SOURCES = unit/test-dpp.c src/dpp-util.h src/dpp-util.c \
> +				src/util.h src/util.c src/crypto.h src/crypto.c

I had to add src/band.[ch] here

> +unit_test_dpp_LDADD = $(ell_ldadd)
> +
>   TESTS = $(unit_tests)
>   
>   EXTRA_DIST = src/genbuiltin src/iwd.service.in src/net.connman.iwd.service \

<snip>

> +const char *i_proto_public_bytes = "50a532ae2a07207276418d2fa630295d45569be425aa634f02014d00a7d1f61a";

I changed some of these data lines to be 80 char / line compliant.

Applied, but I'm seeing this:

TEST: DPP test key derivation

=================================================================
==17289==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 536 byte(s) in 7 object(s) allocated from:
     #0 0x7f88cc96d0f8 in __interceptor_malloc 
(/usr/lib/gcc/x86_64-pc-linux-gnu/9.4.0/libasan.so.5+0x10c0f8)
     #1 0x4199d2 in l_malloc ell/util.c:62

SUMMARY: AddressSanitizer: 536 byte(s) leaked in 7 allocation(s).

Regards,
-Denis