public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH 1/2] dpp: relax requirement on IWD being in a disconnected state
Date: Mon, 22 Jul 2024 04:23:33 -0700	[thread overview]
Message-ID: <14f02ac9-612e-4d12-bf59-d51ec96dc2f6@gmail.com> (raw)
In-Reply-To: <8a021f22-346a-43c1-9b2a-49bcdc1deed5@gmail.com>


On 7/19/24 2:00 PM, Denis Kenzior wrote:
> Hi James,
>
>>>
>>> Have you looked into how WSC does this?
>> I hadn't, but looks like it waits for a disconnected state before 
>> starting? We could do this too in DPP I guess. Just check if station 
>> is in any pending connecting states (connecting/connecting_auto), set 
>> a flag, and start DPP when station signals its disconnected.
>
> My view on this is that the user has explicitly indicated that they 
> want to connect to a new network, so any ongoing autoconnect in 
> station should be canceled.
>
> Also, I think it would be good to be consistent between DPP and WSC.  
> In the end they implement the same use case.  Whatever we do for one 
> should be the same for the other.

Ok we can do this instead. I see that WSC will actually disconnect 
explicitly when its begins, and manages stations autoconnect state. This 
was my only concern with DPP as I didn't want starting an enrollee to 
cancel autoconnect in general in case of failure.

Thanks,

James

>
> Regards,
> -Denis

      reply	other threads:[~2024-07-22 11:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-19 18:19 [PATCH 1/2] dpp: relax requirement on IWD being in a disconnected state James Prestwood
2024-07-19 18:19 ` [PATCH 2/2] auto-t: add test for DPP starting while connecting James Prestwood
2024-07-19 20:33 ` [PATCH 1/2] dpp: relax requirement on IWD being in a disconnected state Denis Kenzior
2024-07-19 20:42   ` James Prestwood
2024-07-19 21:00     ` Denis Kenzior
2024-07-22 11:23       ` James Prestwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=14f02ac9-612e-4d12-bf59-d51ec96dc2f6@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox