public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH] station: fix setting an empty affinities list
Date: Wed, 23 Apr 2025 09:43:15 -0500	[thread overview]
Message-ID: <15229ae4-8069-4fbf-9880-11be9793a35c@gmail.com> (raw)
In-Reply-To: <20250417161601.249876-1-prestwoj@gmail.com>

Hi James,

On 4/17/25 11:16 AM, James Prestwood wrote:
> A prior patch broke this by checking the return of
> l_dbus_message_iter_next_entry. This was really subtle but the logic
> actually relied on _not_ checking that return in order to handle
> empty lists.
> 
> Instead of reverting the logic was adapted/commented to make it more
> clear what the API expects from DBus. If list contains at least one
> value the first element path will get set, if it contains zero
> values "new_path" will be set to NULL which will then cause the
> list to be cleared later on.
> 
> This both fixes the regression, and makes it clear that a zero
> element list is supported and handled.
> ---
>   src/station.c | 12 ++++++++----
>   1 file changed, 8 insertions(+), 4 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

      reply	other threads:[~2025-04-23 14:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-17 16:16 [PATCH] station: fix setting an empty affinities list James Prestwood
2025-04-23 14:43 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15229ae4-8069-4fbf-9880-11be9793a35c@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox