From: Tim Kourt <tim.a.kourt@linux.intel.com>
To: iwd@lists.01.org
Subject: [PATCH 5/8] hotspot Eliminate double assignment of variable
Date: Wed, 23 Oct 2019 13:24:00 -0700 [thread overview]
Message-ID: <20191023202403.9690-5-tim.a.kourt@linux.intel.com> (raw)
In-Reply-To: <20191023202403.9690-1-tim.a.kourt@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
---
src/hotspot.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/hotspot.c b/src/hotspot.c
index 8d2bb04a..a101cbb0 100644
--- a/src/hotspot.c
+++ b/src/hotspot.c
@@ -320,7 +320,7 @@ static struct hs20_config *hs20_config_new(struct l_settings *settings,
char **nai_realms = NULL;
const char *rc_str;
char *name;
- bool autoconnect = true;
+ bool autoconnect;
/* One of HESSID, NAI realms, or Roaming Consortium must be included */
hessid_str = l_settings_get_string(settings, "Hotspot", "HESSID");
@@ -330,7 +330,9 @@ static struct hs20_config *hs20_config_new(struct l_settings *settings,
rc_str = l_settings_get_value(settings, "Hotspot", "RoamingConsortium");
- l_settings_get_bool(settings, "Settings", "Autoconnect", &autoconnect);
+ if (!l_settings_get_bool(settings, "Settings", "Autoconnect",
+ &autoconnect))
+ autoconnect = true;
name = l_settings_get_string(settings, "Hotspot", "Name");
--
2.13.6
next prev parent reply other threads:[~2019-10-23 20:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 20:23 [PATCH 1/8] client: Treat invalid DBus reply same as an error Tim Kourt
2019-10-23 20:23 ` [PATCH 2/8] client: Ignore invalid notifications Tim Kourt
2019-10-23 20:23 ` [PATCH 3/8] client: Ignore invalid agent requests Tim Kourt
2019-10-23 22:51 ` Denis Kenzior
2019-10-23 20:23 ` [PATCH 4/8] hotspot: Fix mem leak on failed hotspot config Tim Kourt
2019-10-23 22:56 ` Denis Kenzior
2019-10-23 20:24 ` Tim Kourt [this message]
2019-10-23 23:00 ` [PATCH 5/8] hotspot Eliminate double assignment of variable Denis Kenzior
2019-10-23 20:24 ` [PATCH 6/8] hwsim: Fix potential memory leak Tim Kourt
2019-10-23 20:24 ` [PATCH 7/8] client: Check family name before comparison Tim Kourt
2019-10-23 20:24 ` [PATCH 8/8] ofono: Validate message parsing Tim Kourt
2019-10-23 22:50 ` [PATCH 1/8] client: Treat invalid DBus reply same as an error Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023202403.9690-5-tim.a.kourt@linux.intel.com \
--to=tim.a.kourt@linux.intel.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox