From: Tim Kourt <tim.a.kourt@linux.intel.com>
To: iwd@lists.01.org
Subject: [PATCH 3/6] peap: Rename AVPs to TLVs
Date: Thu, 05 Dec 2019 13:13:51 -0800 [thread overview]
Message-ID: <20191205211354.19075-3-tim.a.kourt@linux.intel.com> (raw)
In-Reply-To: <20191205211354.19075-1-tim.a.kourt@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2561 bytes --]
Most of the literature seems to refer to AVPs as TLVs. Rename the
variables to follow the common nomenclature.
---
src/eap-peap.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/eap-peap.c b/src/eap-peap.c
index eb0b0c5f..ed18c667 100644
--- a/src/eap-peap.c
+++ b/src/eap-peap.c
@@ -110,13 +110,13 @@ static void eap_peap_phase2_complete(enum eap_result result, void *user_data)
* PEAPv0: draft-kamath-pppext-peapv0-00, Section 2
*/
#define EAP_EXTENSIONS_HEADER_LEN 5
-#define EAP_EXTENSIONS_AVP_HEADER_LEN 4
+#define EAP_EXTENSIONS_TLV_HEADER_LEN 4
-enum eap_extensions_avp_type {
+enum eap_extensions_tlv_type {
/* Reserved = 0x0000, */
/* Reserved = 0x0001, */
/* Reserved = 0x0002, */
- EAP_EXTENSIONS_AVP_TYPE_RESULT = 0x8003,
+ EAP_EXTENSIONS_TLV_TYPE_RESULT = 0x8003,
};
enum eap_extensions_result {
@@ -124,7 +124,7 @@ enum eap_extensions_result {
EAP_EXTENSIONS_RESULT_FAILURE = 2,
};
-static int eap_extensions_handle_result_avp(struct eap_state *eap,
+static int eap_extensions_handle_result_tlv(struct eap_state *eap,
const uint8_t *data,
size_t data_len,
uint8_t *response)
@@ -134,12 +134,12 @@ static int eap_extensions_handle_result_avp(struct eap_state *eap,
uint16_t len;
uint16_t result;
- if (data_len < EAP_EXTENSIONS_AVP_HEADER_LEN + 2)
+ if (data_len < EAP_EXTENSIONS_TLV_HEADER_LEN + 2)
return -ENOENT;
type = l_get_be16(data);
- if (type != EAP_EXTENSIONS_AVP_TYPE_RESULT)
+ if (type != EAP_EXTENSIONS_TLV_TYPE_RESULT)
return -ENOENT;
data += 2;
@@ -169,11 +169,11 @@ static int eap_extensions_handle_result_avp(struct eap_state *eap,
return -ENOENT;
}
- l_put_be16(EAP_EXTENSIONS_AVP_TYPE_RESULT,
+ l_put_be16(EAP_EXTENSIONS_TLV_TYPE_RESULT,
&response[EAP_EXTENSIONS_HEADER_LEN]);
l_put_be16(2, &response[EAP_EXTENSIONS_HEADER_LEN + 2]);
l_put_be16(result, &response[EAP_EXTENSIONS_HEADER_LEN +
- EAP_EXTENSIONS_AVP_HEADER_LEN]);
+ EAP_EXTENSIONS_TLV_HEADER_LEN]);
return result;
}
@@ -185,8 +185,8 @@ static void eap_extensions_handle_request(struct eap_state *eap,
{
struct peap_state *peap_state;
uint8_t response[EAP_EXTENSIONS_HEADER_LEN +
- EAP_EXTENSIONS_AVP_HEADER_LEN + 2];
- int r = eap_extensions_handle_result_avp(eap, pkt, len, response);
+ EAP_EXTENSIONS_TLV_HEADER_LEN + 2];
+ int r = eap_extensions_handle_result_tlv(eap, pkt, len, response);
if (r < 0)
return;
--
2.13.6
next prev parent reply other threads:[~2019-12-05 21:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 21:13 [PATCH 1/6] peap: Introduce PEAP state Tim Kourt
2019-12-05 21:13 ` [PATCH 2/6] peap: Delay key installation until success of Phase 2 Tim Kourt
2019-12-05 21:13 ` Tim Kourt [this message]
2019-12-05 21:13 ` [PATCH 4/6] peap: Extend EAP Extensions to handle multiple TLVs Tim Kourt
2019-12-09 7:46 ` Denis Kenzior
2019-12-05 21:13 ` [PATCH 5/6] crypto: Add support for PRF+ SHA1 Tim Kourt
2019-12-09 7:47 ` Denis Kenzior
2019-12-05 21:13 ` [PATCH 6/6] peap: Add support for Crypto-Binding in PEAPv0 Tim Kourt
2019-12-09 8:00 ` Denis Kenzior
2019-12-09 7:40 ` [PATCH 1/6] peap: Introduce PEAP state Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205211354.19075-3-tim.a.kourt@linux.intel.com \
--to=tim.a.kourt@linux.intel.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox