From: Pinghao Wu <xdavidwuph@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH] eap-gtc: Try to auth even if request not Password
Date: Thu, 12 Dec 2019 09:23:01 +0800 [thread overview]
Message-ID: <20191212012301.2162-1-xdavidwuph@gmail.com> (raw)
In-Reply-To: <66a25792-2327-b3c8-d324-e7b353abcbe1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1323 bytes --]
There are some server implementations that send requests that are
not "Password" but still want us send password. This commit modify
the behavior to send a warning and still try to auth with password.
This makes me able to auth with server in my school which sends
"Enter Aruba Login".
wpa_supplicant does not check if it is "Password".
---
src/eap-gtc.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/src/eap-gtc.c b/src/eap-gtc.c
index 9302257e..7788d44c 100644
--- a/src/eap-gtc.c
+++ b/src/eap-gtc.c
@@ -56,11 +56,9 @@ static void eap_gtc_handle_request(struct eap_state *eap,
size_t secret_len = strlen(gtc->password);
uint8_t response[5 + secret_len];
- if (len < 8)
- goto error;
-
- if (strncmp((const char *)pkt, "Password", 8))
- goto error;
+ if (len < 8 || strncmp((const char *)pkt, "Password", 8))
+ l_warn("GTC request not understood, proceeding anyway: %.*s",
+ (int) len, (const char *) pkt);
memcpy(response + 5, gtc->password, secret_len);
@@ -69,10 +67,6 @@ static void eap_gtc_handle_request(struct eap_state *eap,
eap_method_success(eap);
return;
-
-error:
- l_error("invalid GTC request");
- eap_method_error(eap);
}
static int eap_gtc_check_settings(struct l_settings *settings,
--
2.24.1
next prev parent reply other threads:[~2019-12-12 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 12:39 [PATCH] eap-gtc: Try to auth even if request not Password xdavidwu
2019-12-11 20:57 ` Denis Kenzior
2019-12-12 1:23 ` Pinghao Wu [this message]
2019-12-12 16:24 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212012301.2162-1-xdavidwuph@gmail.com \
--to=xdavidwuph@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox