Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect
Date: Wed, 06 May 2020 08:58:06 -0700	[thread overview]
Message-ID: <20200506155807.4434-1-prestwoj@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

In certain cases the test was reaching this point once already finished
with a scan. This caused the wait for 'scanning' to time out. At this point
in the test we don't need to wait for scanning and only need to wait for
scanning to finish. If scanning is already finished before validation we
can simply validate at that time.
---
 autotests/testConnectAutoconnect/validation.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/autotests/testConnectAutoconnect/validation.py b/autotests/testConnectAutoconnect/validation.py
index 43cbaf02..b1e3accc 100644
--- a/autotests/testConnectAutoconnect/validation.py
+++ b/autotests/testConnectAutoconnect/validation.py
@@ -54,9 +54,6 @@ class TestConnectAutoConnect(unittest.TestCase):
         self.assertIsNotNone(devices)
         device = devices[0]
 
-        condition = 'obj.scanning'
-        wd.wait_for_object_condition(device, condition)
-
         condition = 'not obj.scanning'
         wd.wait_for_object_condition(device, condition)
 
-- 
2.21.1

             reply	other threads:[~2020-05-06 15:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-06 15:58 James Prestwood [this message]
2020-05-06 15:58 ` [PATCH 2/2] auto-t: remove scanning wait from testHiddenNetworks James Prestwood
2020-05-06 16:46 ` [PATCH 1/2] auto-t: remove scanning wait from testConnectAutoconnect Kourt, Tim A
2020-05-06 16:52   ` James Prestwood
2020-05-06 17:02     ` Kourt, Tim A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200506155807.4434-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox