Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 2/4] auto-t: don't clear out rules from hwsim object
Date: Mon, 14 Sep 2020 14:02:31 -0700	[thread overview]
Message-ID: <20200914210233.428835-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20200914210233.428835-1-prestwoj@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 883 bytes --]

This got added in the re-write but a __del__ method was also
added to the Rule class as well. This caused problems if hwsim
cleaned up since it removed the rules, which caused each rule
to call __del__. Since the rule had already been removed there
was no longer a DBus interface which raised an exception.
---
 autotests/util/hwsim.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/autotests/util/hwsim.py b/autotests/util/hwsim.py
index cf1ab536..4f41952f 100755
--- a/autotests/util/hwsim.py
+++ b/autotests/util/hwsim.py
@@ -274,10 +274,6 @@ class Hwsim(iwd.AsyncOpAbstract):
         self._rules = RuleSet(self, objects)
         self._radios = RadioList(self, objects)
 
-    def __del__(self):
-        for rule in self._rules.values():
-            rule.remove()
-
     @property
     def rules(self):
         return self._rules
-- 
2.26.2

  reply	other threads:[~2020-09-14 21:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 21:02 [PATCH 1/4] station: print which BSS is being connected to James Prestwood
2020-09-14 21:02 ` James Prestwood [this message]
2020-09-14 21:02 ` [PATCH 3/4] auto-t: fix testFT-PSK-roam James Prestwood
2020-09-14 21:02 ` [PATCH 4/4] auto-t: replace waiting for network with device James Prestwood
2020-09-14 21:03 ` [PATCH 1/4] station: print which BSS is being connected to Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200914210233.428835-2-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox