Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH] test-runner: use **kwargs for start_process
Date: Tue, 15 Sep 2020 10:36:20 -0700	[thread overview]
Message-ID: <20200915173620.513612-1-prestwoj@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1009 bytes --]

This is just a more concise/pythonic way of doing function arguments.
Since Process/start_process have basically the same argument names
we can simplify and use **kwargs which will pass the named arguments
directly to Process(). This also allows us to add arguments to Process
without touching start_process if we need.
---
 tools/test-runner | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/test-runner b/tools/test-runner
index a71b9ef6..d1e1d42c 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -465,10 +465,10 @@ class TestContext:
 		self.results = {}
 		self.mainloop = GLib.MainLoop()
 
-	def start_process(self, args, wait=False, multi_test=False, env=None, check=False):
-		p = Process(args, wait, multi_test, env, ctx=self, check=check)
+	def start_process(self, args, **kwargs):
+		p = Process(args, ctx=self, **kwargs)
 
-		if not wait:
+		if not kwargs.get('wait', False):
 			self.processes.append(p)
 
 		return p
-- 
2.26.2

             reply	other threads:[~2020-09-15 17:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 17:36 James Prestwood [this message]
2020-09-15 21:46 ` [PATCH] test-runner: use **kwargs for start_process Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200915173620.513612-1-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox