From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 1/4] ap: make APRanges optional
Date: Tue, 03 Nov 2020 11:06:38 -0800 [thread overview]
Message-ID: <20201103190641.2736204-1-prestwoj@gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 980 bytes --]
If EnableNetworkConfiguration was enabled ap.c required that
APRanges also be set. This prevents IWD from starting which
effects a perfectly valid station configuration. Instead if
APRanges is not provided IWD still allows ap_init to pass but
DHCP just will not be enabled.
---
src/ap.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/ap.c b/src/ap.c
index bebd7295..4d0d5686 100644
--- a/src/ap.c
+++ b/src/ap.c
@@ -3028,9 +3028,14 @@ static int ap_init(void)
ip_prefix = l_settings_get_string(settings, "General",
"APRanges");
+ /*
+ * In this case its assumed the user only cares about station
+ * netconfig so we let ap_init pass but DHCP will not be
+ * enabled.
+ */
if (!ip_prefix) {
- l_error("[General].APRanges must be set for DHCP");
- return -EINVAL;
+ l_warn("[General].APRanges must be set for DHCP");
+ return 0;
}
if (!ip_pool_create(ip_prefix))
--
2.26.2
next reply other threads:[~2020-11-03 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 19:06 James Prestwood [this message]
2020-11-03 19:06 ` [PATCH 2/4] auto-t: fix testNetconfig hardcoded interface James Prestwood
2020-11-03 19:06 ` [PATCH 3/4] auto-t: remove /var/lib/iwd references in testKnownNetworks James Prestwood
2020-11-03 19:06 ` [PATCH 4/4] auto-t: fix agent path timing issue James Prestwood
2020-11-03 19:59 ` [PATCH 1/4] ap: make APRanges optional Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103190641.2736204-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox