Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 11/11] auto-t: fix hwsim.py spoof frame
Date: Thu, 17 Dec 2020 11:36:11 -0800	[thread overview]
Message-ID: <20201217193611.1177006-11-prestwoj@gmail.com> (raw)
In-Reply-To: <20201217193611.1177006-1-prestwoj@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1447 bytes --]

After the change creating radios from DBus the radio address pair
seems to come in mismatch order, meaning the radio address at
index zero may not always be what is expected. Instead of hardcoding
addresses[0] the address is checked in the entire addresses array.
---
 autotests/util/hwsim.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/autotests/util/hwsim.py b/autotests/util/hwsim.py
index 9aa14cbc..818bac1e 100755
--- a/autotests/util/hwsim.py
+++ b/autotests/util/hwsim.py
@@ -330,15 +330,15 @@ class Hwsim(iwd.AsyncOpAbstract):
             obj = objects[path]
             for interface in obj:
                 if interface == HWSIM_INTERFACE_INTERFACE:
-                    if obj[interface]['Address'] == radio.addresses[0]:
+                    if obj[interface]['Address'] in radio.addresses:
                         radio_path = path
                         break
 
         iface = dbus.Interface(self._bus.get_object(HWSIM_SERVICE, radio_path),
                 HWSIM_INTERFACE_INTERFACE)
 
-        iface.SendFrame(bytearray.fromhex(station.replace(':', '')),
-                        freq, -30, bytearray.fromhex(frame))
+        iface.SendFrame(dbus.ByteArray(bytearray.fromhex(station.replace(':', ''))),
+                        freq, -30, dbus.ByteArray(bytearray.fromhex(frame)))
 
     def get_radio(self, name):
         for path in self.radios:
-- 
2.26.2

  parent reply	other threads:[~2020-12-17 19:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 19:36 [PATCH 01/11] hwsim: add --no-register option James Prestwood
2020-12-17 19:36 ` [PATCH 02/11] hwsim: check pending_create_msg before replying James Prestwood
2020-12-17 19:36 ` [PATCH 03/11] auto-t: fix hwsim.py to use Destroy rather than Remove James Prestwood
2020-12-17 19:36 ` [PATCH 04/11] hwsim: change radio Create() to take a dictionary James Prestwood
2020-12-17 19:36 ` [PATCH 05/11] auto-t: update hwsim radio create to use dictionary James Prestwood
2020-12-17 19:36 ` [PATCH 06/11] test-runner: add wait_for_dbus_service James Prestwood
2020-12-17 19:36 ` [PATCH 07/11] test-runner: start hwsim always (optionally --no-register) James Prestwood
2020-12-17 19:36 ` [PATCH 08/11] hwsim: add iftype/cipher disabling through DBus James Prestwood
2020-12-17 19:36 ` [PATCH 09/11] auto-t: add iftype/cipher disable to hwsim.py James Prestwood
2020-12-17 19:36 ` [PATCH 10/11] test-runner: Use DBus for hwsim radios James Prestwood
2020-12-17 19:36 ` James Prestwood [this message]
2020-12-18  2:15 ` [PATCH 01/11] hwsim: add --no-register option Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201217193611.1177006-11-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox