Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH v2 6/6] station: set handshake offload if required
Date: Mon, 22 Mar 2021 09:01:56 -0700	[thread overview]
Message-ID: <20210322160156.392256-6-prestwoj@gmail.com> (raw)
In-Reply-To: <20210322160156.392256-1-prestwoj@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

If IWD is connecting to a SAE/WPA3 BSS and Auth/Assoc commands
are not supported the only option is SAE offload. At this point
network_connect should have verified that the extended feature
for SAE offload exists so we can simply enable offload if these
commands are not supported.
---
 src/station.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/station.c b/src/station.c
index 2e577290..385dc7da 100644
--- a/src/station.c
+++ b/src/station.c
@@ -979,6 +979,16 @@ static struct handshake_state *station_handshake_setup(struct station *station,
 				goto no_psk;
 
 			handshake_state_set_passphrase(hs, passphrase);
+
+			/*
+			 * TODO: This check isn't strictly correct since
+			 * some drivers may support EXTERNAL_AUTH but since
+			 * wiphy_can_connect takes this into account IWD should
+			 * have already rejected the connection if this was the
+			 * case.
+			 */
+			if (!wiphy_supports_cmds_auth_assoc(wiphy))
+				hs->offload = true;
 		} else {
 			const uint8_t *psk = network_get_psk(network);
 
-- 
2.26.2

  parent reply	other threads:[~2021-03-22 16:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-22 16:01 [PATCH v2 1/6] wiphy: add getter for 'supports_cmds_auth_assoc' James Prestwood
2021-03-22 16:01 ` [PATCH v2 2/6] wiphy: check SAE offload in wiphy_select_akm James Prestwood
2021-03-22 16:01 ` [PATCH v2 3/6] wiphy: check SAE offload in wiphy_can_connect James Prestwood
2021-03-22 16:01 ` [PATCH v2 4/6] handshake: add offload flag James Prestwood
2021-03-22 16:01 ` [PATCH v2 5/6] netdev: add SAE offload support James Prestwood
2021-03-22 16:01 ` James Prestwood [this message]
2021-03-22 19:17 ` [PATCH v2 1/6] wiphy: add getter for 'supports_cmds_auth_assoc' Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210322160156.392256-6-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox