From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH v2 2/3] sae: add counter for associate retries
Date: Mon, 29 Mar 2021 13:43:50 -0700 [thread overview]
Message-ID: <20210329204351.718429-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20210329204351.718429-1-prestwoj@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]
If there is an associate timeout, retry a few times in case
it was just a fluke. At this point SAE is fully negotiated
so it makes sense to attempt to save the connection.
---
src/sae.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/src/sae.c b/src/sae.c
index ade5e24c..b6cc0b15 100644
--- a/src/sae.c
+++ b/src/sae.c
@@ -37,6 +37,7 @@
#define SAE_RETRANSMIT_TIMEOUT 2
#define SAE_SYNC_MAX 3
+#define SAE_MAX_ASSOC_RETRY 3
enum sae_state {
SAE_STATE_NOTHING = 0,
@@ -73,6 +74,7 @@ struct sae_sm {
uint16_t rc;
/* remote peer */
uint8_t peer[6];
+ uint8_t assoc_retry;
sae_tx_authenticate_func_t tx_auth;
sae_tx_associate_func_t tx_assoc;
@@ -670,7 +672,7 @@ static bool sae_send_commit(struct sae_sm *sm, bool retry)
return true;
}
-static bool sae_timeout(struct auth_proto *ap)
+static bool sae_auth_timeout(struct auth_proto *ap)
{
struct sae_sm *sm = l_container_of(ap, struct sae_sm, ap);
@@ -699,6 +701,20 @@ static bool sae_timeout(struct auth_proto *ap)
return true;
}
+static bool sae_assoc_timeout(struct auth_proto *ap)
+{
+ struct sae_sm *sm = l_container_of(ap, struct sae_sm, ap);
+
+ if (sm->assoc_retry >= SAE_MAX_ASSOC_RETRY)
+ return false;
+
+ sm->assoc_retry++;
+
+ sm->tx_assoc(sm->user_data);
+
+ return true;
+}
+
/*
* 802.11-2016 - Section 12.4.8.6.4
* If the Status code is ANTI_CLOGGING_TOKEN_REQUIRED, a new SAE Commit message
@@ -1178,7 +1194,8 @@ struct auth_proto *sae_sm_new(struct handshake_state *hs,
sm->ap.free = sae_free;
sm->ap.rx_authenticate = sae_rx_authenticate;
sm->ap.rx_associate = sae_rx_associate;
- sm->ap.auth_timeout = sae_timeout;
+ sm->ap.auth_timeout = sae_auth_timeout;
+ sm->ap.assoc_timeout = sae_assoc_timeout;
return &sm->ap;
}
--
2.26.2
next prev parent reply other threads:[~2021-03-29 20:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-29 20:43 [PATCH v2 1/3] netdev: better handle associate timeouts with auth_protos James Prestwood
2021-03-29 20:43 ` James Prestwood [this message]
2021-03-29 20:43 ` [PATCH v2 3/3] netdev: remove unneeded goto/return code James Prestwood
2021-03-29 20:50 ` [PATCH v2 1/3] netdev: better handle associate timeouts with auth_protos Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210329204351.718429-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox