From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH 2/2] offchannel: always use -ECANCELED for cancelation
Date: Thu, 16 Dec 2021 10:00:03 -0800 [thread overview]
Message-ID: <20211216180003.38883-2-prestwoj@gmail.com> (raw)
In-Reply-To: 20211216180003.38883-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
info->error gets reset to zero on a successful ROC callback
which was getting used for cancelation.
---
src/offchannel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/offchannel.c b/src/offchannel.c
index 4db3fcf2..e01f76c7 100644
--- a/src/offchannel.c
+++ b/src/offchannel.c
@@ -231,7 +231,7 @@ void offchannel_cancel(uint64_t wdev_id, uint32_t id)
destroy:
if (info->destroy)
- info->destroy(info->error, info->user_data);
+ info->destroy(-ECANCELED, info->user_data);
info->destroy = NULL;
info->started = NULL;
--
2.31.1
next reply other threads:[~2021-12-16 18:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 18:00 James Prestwood [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-12-16 18:21 [PATCH 2/2] offchannel: always use -ECANCELED for cancelation Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216180003.38883-2-prestwoj@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox