* [PATCH 2/2] offchannel: always use -ECANCELED for cancelation
@ 2021-12-16 18:00 James Prestwood
0 siblings, 0 replies; 2+ messages in thread
From: James Prestwood @ 2021-12-16 18:00 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
info->error gets reset to zero on a successful ROC callback
which was getting used for cancelation.
---
src/offchannel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/offchannel.c b/src/offchannel.c
index 4db3fcf2..e01f76c7 100644
--- a/src/offchannel.c
+++ b/src/offchannel.c
@@ -231,7 +231,7 @@ void offchannel_cancel(uint64_t wdev_id, uint32_t id)
destroy:
if (info->destroy)
- info->destroy(info->error, info->user_data);
+ info->destroy(-ECANCELED, info->user_data);
info->destroy = NULL;
info->started = NULL;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] offchannel: always use -ECANCELED for cancelation
@ 2021-12-16 18:21 Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2021-12-16 18:21 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
Hi James,
On 12/16/21 12:00, James Prestwood wrote:
> info->error gets reset to zero on a successful ROC callback
> which was getting used for cancelation.
> ---
> src/offchannel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-16 18:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-16 18:00 [PATCH 2/2] offchannel: always use -ECANCELED for cancelation James Prestwood
-- strict thread matches above, loose matches on Subject: below --
2021-12-16 18:21 Denis Kenzior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox