From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH 2/2] auto-t: iwd.py: fix namespaces on StationDebug
Date: Wed, 22 Dec 2021 17:12:22 -0800 [thread overview]
Message-ID: <20211223011222.20509-2-prestwoj@gmail.com> (raw)
In-Reply-To: 20211223011222.20509-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]
Passing the full argument list to StationDebug was removed
because any existing properties (for Device) were being
included and causing incorrect behavior.
This neglected to handle namespaces which should also be
passed to StationDebug. Unfortunately the arguments are not
named when Device() is initialized so they cannot easily be
sorted. Instead just define Device() arguments to match the
DBus abstraction and pass only the path and namespace to
StationDebug
---
autotests/util/iwd.py | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/autotests/util/iwd.py b/autotests/util/iwd.py
index 185a31fe..e95bd96d 100755
--- a/autotests/util/iwd.py
+++ b/autotests/util/iwd.py
@@ -280,14 +280,17 @@ class Device(IWDDBusAbstract):
'''
_iface_name = IWD_DEVICE_INTERFACE
- def __init__(self, *args, **kwargs):
+ def __init__(self, object_path = None, properties = None,
+ service=IWD_SERVICE, namespace=ctx):
self._wps_manager_if = None
self._station_if = None
self._station_props = None
- IWDDBusAbstract.__init__(self, *args, **kwargs)
+ IWDDBusAbstract.__init__(self, object_path, properties, service,
+ namespace)
- self._station_debug = StationDebug(args[0])
+ self._station_debug = StationDebug(object_path=object_path,
+ namespace=namespace)
@property
def _wps_manager(self):
--
2.31.1
reply other threads:[~2021-12-23 1:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223011222.20509-2-prestwoj@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox