public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH 2/2] auto-t: iwd.py: fix namespaces on StationDebug
@ 2021-12-23  1:12 James Prestwood
  0 siblings, 0 replies; only message in thread
From: James Prestwood @ 2021-12-23  1:12 UTC (permalink / raw)
  To: iwd 

[-- Attachment #1: Type: text/plain, Size: 1544 bytes --]

Passing the full argument list to StationDebug was removed
because any existing properties (for Device) were being
included and causing incorrect behavior.

This neglected to handle namespaces which should also be
passed to StationDebug. Unfortunately the arguments are not
named when Device() is initialized so they cannot easily be
sorted. Instead just define Device() arguments to match the
DBus abstraction and pass only the path and namespace to
StationDebug
---
 autotests/util/iwd.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/autotests/util/iwd.py b/autotests/util/iwd.py
index 185a31fe..e95bd96d 100755
--- a/autotests/util/iwd.py
+++ b/autotests/util/iwd.py
@@ -280,14 +280,17 @@ class Device(IWDDBusAbstract):
     '''
     _iface_name = IWD_DEVICE_INTERFACE
 
-    def __init__(self, *args, **kwargs):
+    def __init__(self, object_path = None, properties = None,
+                    service=IWD_SERVICE, namespace=ctx):
         self._wps_manager_if = None
         self._station_if = None
         self._station_props = None
 
-        IWDDBusAbstract.__init__(self, *args, **kwargs)
+        IWDDBusAbstract.__init__(self, object_path, properties, service,
+                                    namespace)
 
-        self._station_debug = StationDebug(args[0])
+        self._station_debug = StationDebug(object_path=object_path,
+                                            namespace=namespace)
 
     @property
     def _wps_manager(self):
-- 
2.31.1

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2021-12-23  1:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-23  1:12 [PATCH 2/2] auto-t: iwd.py: fix namespaces on StationDebug James Prestwood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox