From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH 3/5] dpp: move r_auth into dpp_sm
Date: Fri, 07 Jan 2022 14:31:10 -0800 [thread overview]
Message-ID: <20220107223112.715855-3-prestwoj@gmail.com> (raw)
In-Reply-To: 20220107223112.715855-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 2298 bytes --]
In order to support channel switching during authentication r_auth
needs to be held onto in dpp_sm for after the ROC call starts.
---
src/dpp.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/dpp.c b/src/dpp.c
index 5d52e007..25359075 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -102,6 +102,7 @@ struct dpp_sm {
uint64_t ke[L_ECC_MAX_DIGITS];
uint64_t k2[L_ECC_MAX_DIGITS];
+ uint64_t r_auth[L_ECC_MAX_DIGITS];
struct l_ecc_scalar *proto_private;
struct l_ecc_point *proto_public;
@@ -967,7 +968,7 @@ static void dpp_handle_config_result_frame(struct dpp_sm *dpp,
* ad1 = attrs
* ad1_len = ptr - attrs
*/
-static void send_authenticate_response(struct dpp_sm *dpp, void *r_auth)
+static void send_authenticate_response(struct dpp_sm *dpp)
{
uint8_t hdr[32];
uint8_t attrs[256];
@@ -998,7 +999,7 @@ static void send_authenticate_response(struct dpp_sm *dpp, void *r_auth)
/* Wrap up secondary data (R-Auth) */
wrapped2_len = dpp_append_attr(wrapped2_plaintext,
DPP_ATTR_RESPONDER_AUTH_TAG,
- r_auth, dpp->key_len);
+ dpp->r_auth, dpp->key_len);
/*
* "Invocations of AES-SIV in the DPP Authentication protocol that
* produce ciphertext that is part of an additional AES-SIV invocation
@@ -1222,7 +1223,6 @@ static void authenticate_request(struct dpp_sm *dpp, const uint8_t *from,
_auto_(l_ecc_scalar_free) struct l_ecc_scalar *m = NULL;
_auto_(l_ecc_scalar_free) struct l_ecc_scalar *n = NULL;
uint64_t k1[L_ECC_MAX_DIGITS];
- uint64_t r_auth[L_ECC_MAX_DIGITS];
const void *ad0 = body + 2;
const void *ad1 = body + 8;
@@ -1363,7 +1363,7 @@ static void authenticate_request(struct dpp_sm *dpp, const uint8_t *from,
if (!dpp_derive_r_auth(dpp->i_nonce, dpp->r_nonce, dpp->nonce_len,
dpp->i_proto_public, dpp->proto_public,
- dpp->boot_public, r_auth))
+ dpp->boot_public, dpp->r_auth))
goto auth_request_failed;
memcpy(dpp->auth_addr, from, 6);
@@ -1371,7 +1371,7 @@ static void authenticate_request(struct dpp_sm *dpp, const uint8_t *from,
dpp->state = DPP_STATE_AUTHENTICATING;
dpp_reset_protocol_timer(dpp);
- send_authenticate_response(dpp, r_auth);
+ send_authenticate_response(dpp);
return;
--
2.31.1
reply other threads:[~2022-01-07 22:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220107223112.715855-3-prestwoj@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox