From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH 04/10] dpp: put no station device print behind else if
Date: Tue, 11 Jan 2022 16:55:52 -0800 [thread overview]
Message-ID: <20220112005558.1158405-4-prestwoj@gmail.com> (raw)
In-Reply-To: 20220112005558.1158405-1-prestwoj@gmail.com
[-- Attachment #1: Type: text/plain, Size: 951 bytes --]
The previous (incorrect) else was removed since it ended up
printing in most cases since the if clause returned. This should
have been an else if conditional from the start and only print if the
station device was not found.
---
src/dpp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/dpp.c b/src/dpp.c
index c10ec978..5e07a61a 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -1717,9 +1717,8 @@ static struct l_dbus_message *dpp_dbus_start_enrollee(struct l_dbus *dbus,
if (station && station_get_connected_network(station)) {
l_warn("cannot be enrollee while connected, please disconnect");
return dbus_error_busy(message);
- }
-
- l_debug("No station device, continuing anyways...");
+ } else if (!station)
+ l_debug("No station device, continuing anyways...");
dpp->uri = dpp_generate_uri(dpp->pub_asn1, dpp->pub_asn1_len, 2,
netdev_get_address(dpp->netdev), &freq,
--
2.31.1
next reply other threads:[~2022-01-12 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 0:55 James Prestwood [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-01-12 15:39 [PATCH 04/10] dpp: put no station device print behind else if Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220112005558.1158405-4-prestwoj@gmail.com \
--to=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox