Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH v2 1/2] test-runner: use type=os.path.abspath for argparse
Date: Tue, 05 Apr 2022 15:40:29 -0700	[thread overview]
Message-ID: <20220405224030.884883-1-prestwoj@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2130 bytes --]

This is a convenient type which automatically resolves the argument
to an absolute path. Use this for any arguments expected to be
paths.
---
 tools/runner.py | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/tools/runner.py b/tools/runner.py
index 0068c74f..8e1ac1d7 100644
--- a/tools/runner.py
+++ b/tools/runner.py
@@ -97,7 +97,8 @@ class RunnerCoreArgParse(ArgumentParser):
 		self.add_argument('--start', '-s',
 				help='Custom init process in virtual environment',
 				dest='start',
-				default=None)
+				default=None,
+				type=os.path.abspath)
 		self.add_argument('--verbose', '-v', metavar='<list>',
 				type=str,
 				help='Comma separated list of applications',
@@ -108,16 +109,17 @@ class RunnerCoreArgParse(ArgumentParser):
 				help='Enable test-runner debugging',
 				dest='dbg')
 		self.add_argument('--log', '-l',
-				type=str,
+				type=os.path.abspath,
 				help='Directory for log files')
 		self.add_argument('--monitor', '-m',
-				type=str,
+				type=os.path.abspath,
 				help='Enables iwmon output to file')
 		self.add_argument('--sub-tests', '-S',
 				metavar='<subtests>',
 				type=str, nargs=1, help='List of subtests to run',
 				default=None, dest='sub_tests')
-		self.add_argument('--result', '-e', type=str,
+		self.add_argument('--result', '-e',
+				type=os.path.abspath,
 				help='Writes PASS/FAIL to results file')
 		self.add_argument('--hw', '-w',
 				type=str,
@@ -211,8 +213,6 @@ class Runner:
 				args.start = os.path.abspath('tools/run-tests')
 			else:
 				raise Exception("Cannot locate run-tests binary")
-		else:
-			args.start = os.path.abspath(args.start)
 
 		# If no runner is specified but we have a kernel image assume
 		# if the kernel is executable its UML, otherwise qemu
@@ -242,9 +242,6 @@ class RunnerAbstract:
 	def __init__(self, args):
 		self.args = args
 
-		if self.args.log:
-			self.args.log = os.path.abspath(self.args.log)
-
 	def start(self):
 		print("Starting %s" % self.name)
 		os.execlpe(self.cmdline[0], *self.cmdline, self.env)
-- 
2.34.1

             reply	other threads:[~2022-04-05 22:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-05 22:40 James Prestwood [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-04-05 22:50 [PATCH v2 1/2] test-runner: use type=os.path.abspath for argparse Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220405224030.884883-1-prestwoj@gmail.com \
    --to=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox