Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj at gmail.com>
To: iwd at lists.01.org
Subject: [PATCH 2/2] auto-t: allow wildcard phase1 for EAP tests
Date: Wed, 01 Jun 2022 09:05:48 -0700	[thread overview]
Message-ID: <20220601160548.262018-2-prestwoj@gmail.com> (raw)
In-Reply-To: 20220601160548.262018-1-prestwoj@gmail.com

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

This allows the EAP tests to pass, but the fix really needs to be in
hostapd itself. Hostapd currently tries to lookup the EAP session
immediately after receiving EAPOL_REAUTH. This uses the identity
it has stored which, in the case of PEAP/TTLS, will always be a phase2
identity. During this initial lookup hostapd hard codes the identity
to be phase1 which is not true for PEAP/TTLS, and the lookup fails.
---
 autotests/misc/secrets/eap-user.text | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/autotests/misc/secrets/eap-user.text b/autotests/misc/secrets/eap-user.text
index 6f64b2f8..a34726d4 100644
--- a/autotests/misc/secrets/eap-user.text
+++ b/autotests/misc/secrets/eap-user.text
@@ -20,3 +20,8 @@
 "ttls-mschapv2-phase2(a)example.com"	TTLS-MSCHAPV2	"Password" [2]
 "ttls-pap-phase2(a)example.com"		TTLS-PAP	"Password" [2]
 "112345678(a)phonesim.org"		SIM [2]
+
+# TODO: Hostapd is broken with phase1 lookups for reauthentication.
+# Allowing a wildcard phase1 for PEAP/TTLS is a stop gap until
+# hostapd is actually fixed.
+*					PEAP,TTLS
-- 
2.34.1

                 reply	other threads:[~2022-06-01 16:05 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220601160548.262018-2-prestwoj@gmail.com \
    --to=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox