From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v3 1/4] dpp: remove duplicate connected network check
Date: Mon, 13 Nov 2023 09:53:58 -0800 [thread overview]
Message-ID: <20231113175401.343239-1-prestwoj@gmail.com> (raw)
---
src/dpp.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
v3:
* Just removed the extra check. Requiring DISCONNECTED is a bit
strict since its ok if station is in an autoconnecting state
(just as long as it doesn't actually connect)
diff --git a/src/dpp.c b/src/dpp.c
index 23010a05..3a740916 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -4001,14 +4001,8 @@ static uint32_t *dpp_default_freqs(struct dpp_sm *dpp, size_t *out_len)
static bool dpp_start_pkex_enrollee(struct dpp_sm *dpp, const char *key,
const char *identifier)
{
- struct station *station = station_find(netdev_get_ifindex(dpp->netdev));
_auto_(l_ecc_point_free) struct l_ecc_point *qi = NULL;
- if (station && station_get_connected_network(station)) {
- l_debug("Already connected, disconnect before enrolling");
- return false;
- }
-
if (identifier)
dpp->pkex_id = l_strdup(identifier);
@@ -4120,7 +4114,7 @@ static struct l_dbus_message *dpp_dbus_pkex_start_enrollee(struct l_dbus *dbus,
dpp->interface != DPP_INTERFACE_UNBOUND)
return dbus_error_busy(message);
- if (station_get_connected_network(station))
+ if (station && station_get_connected_network(station))
return dbus_error_busy(message);
if (!dpp_parse_pkex_args(message, &key, &id))
--
2.25.1
next reply other threads:[~2023-11-13 17:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 17:53 James Prestwood [this message]
2023-11-13 17:53 ` [PATCH v3 2/4] dpp: add station watch to DPP James Prestwood
2023-11-13 17:54 ` [PATCH v3 3/4] dpp: fix fragile scan/connecting logic James Prestwood
2023-11-16 15:18 ` Denis Kenzior
2023-11-16 15:51 ` James Prestwood
2023-11-13 17:54 ` [PATCH v3 4/4] dpp: scan to pick up extra frequencies when enrolling James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231113175401.343239-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox