From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 1/3] dpp-util: store SSID as string, not raw buffer
Date: Thu, 16 Nov 2023 10:44:57 -0800 [thread overview]
Message-ID: <20231116184459.292601-1-prestwoj@gmail.com> (raw)
Nearly every use of the ssid member first has to memcpy it to a
buffer and NULL terminate. Instead just store the ssid as a
string when creating/parsing from JSON.
---
src/dpp-util.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/dpp-util.h b/src/dpp-util.h
index b5fc029c..222ba053 100644
--- a/src/dpp-util.h
+++ b/src/dpp-util.h
@@ -112,7 +112,7 @@ enum dpp_attribute_type {
};
struct dpp_configuration {
- uint8_t ssid[32];
+ char ssid[33];
size_t ssid_len;
uint32_t akm_suites;
char *passphrase;
--
2.34.1
next reply other threads:[~2023-11-16 18:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 18:44 James Prestwood [this message]
2023-11-16 18:44 ` [PATCH v2 2/3] dpp: use the new config->ssid member James Prestwood
2023-11-16 18:44 ` [PATCH v2 3/3] dpp: use the config's SSID to process scan results James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116184459.292601-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox