From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH v2 3/6] netdev: Don't duplicate vendor_ies
Date: Sun, 26 Nov 2023 22:38:43 -0600 [thread overview]
Message-ID: <20231127043924.1328538-3-denkenz@gmail.com> (raw)
In-Reply-To: <20231127043924.1328538-1-denkenz@gmail.com>
vendor_ies stored in handshake_state are already added as part of
netdev_populate_common_ies(), which is already invoked by
netdev_build_cmd_connect().
Normally vendor_ies is NULL for OWE connections, so no IEs are
duplicated as a result.
---
src/netdev.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/src/netdev.c b/src/netdev.c
index 1c032b32acdc..e7b502b1c3ba 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -2561,16 +2561,11 @@ static void netdev_cmd_connect_cb(struct l_genl_msg *msg, void *user_data)
static bool netdev_retry_owe(struct netdev *netdev)
{
- struct iovec iov;
-
if (!owe_next_group(netdev->owe_sm))
return false;
- iov.iov_base = netdev->handshake->vendor_ies;
- iov.iov_len = netdev->handshake->vendor_ies_len;
-
netdev->connect_cmd = netdev_build_cmd_connect(netdev,
- netdev->handshake, NULL, &iov, 1);
+ netdev->handshake, NULL, NULL, 0);
netdev->connect_cmd_id = l_genl_family_send(nl80211,
netdev->connect_cmd,
--
2.42.0
next prev parent reply other threads:[~2023-11-27 4:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-27 4:38 [PATCH v2 1/6] ie: Move AKM suite converter from netdev Denis Kenzior
2023-11-27 4:38 ` [PATCH v2 2/6] nl80211util: Move nl80211_append_rsn_attributes Denis Kenzior
2023-11-27 4:38 ` Denis Kenzior [this message]
2023-11-27 4:38 ` [PATCH v2 4/6] netdev: Do not leak l_genl_msg on error Denis Kenzior
2023-11-27 4:38 ` [PATCH v2 5/6] netdev: Fix buffer overflow with 32 character ssids Denis Kenzior
2023-11-27 4:38 ` [PATCH v2 6/6] erp: Fix buffer overflow for 32 byte SSIDs Denis Kenzior
2023-11-27 10:30 ` [PATCH v2 1/6] ie: Move AKM suite converter from netdev Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127043924.1328538-3-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox