From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 3/3] netdev: hack back in disconnect event
Date: Tue, 5 Dec 2023 09:52:03 -0800 [thread overview]
Message-ID: <20231205175203.1935692-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20231205175203.1935692-1-prestwoj@gmail.com>
Not sure how we want to address this, but FT is special in that it
has no connect_cb but can still trigger an associate timeout.
Currently if FT times out associating IWD will hang indefinitely.
This behavior can be tested with the prior autotest patches (without
this patch applied).
Fixes: 30c6a10f28 ("netdev: Separate connect_failed and disconnected paths")
---
src/netdev.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/netdev.c b/src/netdev.c
index f2e887b4..2d1120c4 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -3045,7 +3045,13 @@ static void netdev_associate_event(struct l_genl_msg *msg,
* out. The failed connection must be explicitly
* initiated here.
*/
- netdev_connect_failed(netdev,
+ if (!netdev->ap) {
+ if (netdev->event_filter)
+ netdev->event_filter(netdev,
+ NETDEV_EVENT_DISCONNECT_BY_SME,
+ NULL, netdev->user_data);
+ } else
+ netdev_connect_failed(netdev,
NETDEV_RESULT_ASSOCIATION_FAILED,
status_code);
return;
--
2.34.1
next prev parent reply other threads:[~2023-12-05 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 17:52 [PATCH 1/3] auto-t: add explicit stop() to IWD class James Prestwood
2023-12-05 17:52 ` [PATCH 2/3] auto-t: add association timeout test James Prestwood
2023-12-05 17:52 ` James Prestwood [this message]
2023-12-05 21:37 ` [PATCH 3/3] netdev: hack back in disconnect event Denis Kenzior
2023-12-05 21:45 ` James Prestwood
2023-12-05 21:53 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205175203.1935692-3-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox