From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 7/9] station: use netdev_ft_reassociate
Date: Wed, 6 Dec 2023 07:07:06 -0800 [thread overview]
Message-ID: <20231206150708.2080336-8-prestwoj@gmail.com> (raw)
In-Reply-To: <20231206150708.2080336-1-prestwoj@gmail.com>
Using this will provide netdev with a connect callback and unify the
roaming result notification between FT and reassociation. Both paths
will now end up in station_reassociate_cb.
Fixes: 30c6a10f28 ("netdev: Separate connect_failed and disconnected paths")
---
src/station.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/src/station.c b/src/station.c
index 48a595dc..b5e78a37 100644
--- a/src/station.c
+++ b/src/station.c
@@ -2181,7 +2181,8 @@ static void station_reassociate_cb(struct netdev *netdev,
l_debug("%u, result: %d", netdev_get_ifindex(station->netdev), result);
- if (station->state != STATION_STATE_ROAMING)
+ if (station->state != STATION_STATE_ROAMING &&
+ station->state != STATION_STATE_FT_ROAMING)
return;
if (result == NETDEV_RESULT_OK)
@@ -2314,7 +2315,8 @@ static bool station_ft_work_ready(struct wiphy_radio_work_item *item)
if (!bss)
goto try_next;
- ret = ft_associate(netdev_get_ifindex(station->netdev), bss->addr);
+ ret = ft_handshake_setup(netdev_get_ifindex(station->netdev),
+ bss->addr);
switch (ret) {
case MMPDU_STATUS_CODE_INVALID_PMKID:
/*
@@ -2343,6 +2345,13 @@ try_next:
station_transition_start(station);
break;
case 0:
+ ret = netdev_ft_reassociate(station->netdev, bss,
+ station->connected_bss,
+ station_netdev_event,
+ station_reassociate_cb, station);
+ if (ret < 0)
+ goto roam_failed;
+
station->connected_bss = bss;
station->preparing_roam = false;
station_enter_state(station, STATION_STATE_FT_ROAMING);
@@ -2354,6 +2363,7 @@ try_next:
if (ret > 0)
goto try_next;
+roam_failed:
station_roam_failed(station);
break;
}
--
2.34.1
next prev parent reply other threads:[~2023-12-06 15:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 15:06 [PATCH v2 0/9] Reassoc/FT roaming unification James Prestwood
2023-12-06 15:07 ` [PATCH v2 1/9] auto-t: add explicit stop() to IWD class James Prestwood
2023-12-06 15:07 ` [PATCH v2 2/9] auto-t: add association timeout test James Prestwood
2023-12-06 15:07 ` [PATCH v2 3/9] auto-t: only call set_value for changed values in default() James Prestwood
2023-12-06 15:07 ` [PATCH v2 4/9] ft: add FTE/RSNE building to ft_prepare_handshake James Prestwood
2023-12-06 16:36 ` Denis Kenzior
2023-12-06 17:08 ` James Prestwood
2023-12-06 17:14 ` Denis Kenzior
2023-12-06 17:59 ` James Prestwood
2023-12-06 15:07 ` [PATCH v2 5/9] ft: add ft_handshake_setup James Prestwood
2023-12-06 16:38 ` Denis Kenzior
2023-12-06 16:46 ` James Prestwood
2023-12-06 15:07 ` [PATCH v2 6/9] netdev: add netdev_ft_reassociate James Prestwood
2023-12-06 16:40 ` Denis Kenzior
2023-12-06 16:49 ` James Prestwood
2023-12-06 15:07 ` James Prestwood [this message]
2023-12-06 15:07 ` [PATCH v2 8/9] ft: remove ft_associate and helpers James Prestwood
2023-12-06 15:07 ` [PATCH v2 9/9] netdev: station: remove NETDEV_EVENT_FT_ROAMED James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231206150708.2080336-8-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox