From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 1/2] netconfig: limit DHCPv4 attempts to avoid extended netconfig times
Date: Tue, 30 Jan 2024 09:50:37 -0800 [thread overview]
Message-ID: <20240130175038.77908-1-prestwoj@gmail.com> (raw)
ELL now has a setting to limit the number of DHCP attempts. This
will now be set in IWD and if reached will result in a failure
event, and in turn a disconnect.
IWD will set a maximum of 4 retries which should keep the maximum
DHCP time to ~60 seconds roughly.
---
src/netconfig.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/src/netconfig.c b/src/netconfig.c
index 52307025..b31209cf 100644
--- a/src/netconfig.c
+++ b/src/netconfig.c
@@ -50,6 +50,8 @@
#include "src/netconfig.h"
#include "src/sysfs.h"
+#define DHCP_ATTEMPTS 4
+
/*
* Routing priority offset, configurable in main.conf. The route with lower
* priority offset is preferred.
@@ -696,6 +698,7 @@ struct netconfig *netconfig_new(uint32_t ifindex)
int dhcp_priority = L_LOG_INFO;
struct l_dhcp6_client *dhcp6;
struct l_icmp6_client *icmp6;
+ struct l_dhcp_client *dhcp;
l_debug("Creating netconfig for interface: %d", ifindex);
@@ -723,8 +726,8 @@ struct netconfig *netconfig_new(uint32_t ifindex)
l_netconfig_set_event_handler(netconfig->nc, netconfig_event_handler,
netconfig, NULL);
- l_dhcp_client_set_debug(l_netconfig_get_dhcp_client(netconfig->nc),
- do_debug, "[DHCPv4] ", NULL, dhcp_priority);
+ dhcp = l_netconfig_get_dhcp_client(netconfig->nc);
+ l_dhcp_client_set_max_attempts(dhcp, DHCP_ATTEMPTS);
dhcp6 = l_netconfig_get_dhcp6_client(netconfig->nc);
l_dhcp6_client_set_lla_randomized(dhcp6, true);
@@ -735,6 +738,8 @@ struct netconfig *netconfig_new(uint32_t ifindex)
if (debug_level) {
l_dhcp6_client_set_debug(dhcp6, do_debug, "[DHCPv6] ", NULL);
l_icmp6_client_set_debug(icmp6, do_debug, "[ICMPv6] ", NULL);
+ l_dhcp_client_set_debug(dhcp, do_debug, "[DHCPv4] ", NULL,
+ dhcp_priority);
}
return netconfig;
--
2.34.1
next reply other threads:[~2024-01-30 17:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 17:50 James Prestwood [this message]
2024-01-30 17:50 ` [PATCH v2 2/2] auto-t: add netconfig timeout test James Prestwood
2024-01-30 20:00 ` [PATCH v2 1/2] netconfig: limit DHCPv4 attempts to avoid extended netconfig times Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130175038.77908-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox