From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 06/11] netdev: add NETDEV_EVENT_ECC_GROUP_RETRY, handle in station
Date: Tue, 27 Feb 2024 10:34:00 -0800 [thread overview]
Message-ID: <20240227183405.257206-6-prestwoj@gmail.com> (raw)
In-Reply-To: <20240227183405.257206-1-prestwoj@gmail.com>
In order to complete the learned default group behavior station needs
to be aware of when an SAE/OWE connection retried. This is all
handled within netdev/sae so add a new netdev event so station can
set the appropriate network flags to prevent trying the non-default
group again.
---
src/netdev.c | 15 +++++++++++++++
src/netdev.h | 1 +
src/station.c | 15 +++++++++++++++
3 files changed, 31 insertions(+)
diff --git a/src/netdev.c b/src/netdev.c
index d80ce10f..09fac959 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -2559,6 +2559,10 @@ static bool netdev_retry_owe(struct netdev *netdev)
if (!owe_next_group(netdev->owe_sm))
return false;
+ if (netdev->event_filter)
+ netdev->event_filter(netdev, NETDEV_EVENT_ECC_GROUP_RETRY,
+ NULL, netdev->user_data);
+
connect_cmd = netdev_build_cmd_connect(netdev, netdev->handshake, NULL);
netdev->connect_cmd_id = l_genl_family_send(nl80211, connect_cmd,
@@ -2966,6 +2970,17 @@ static void netdev_authenticate_event(struct l_genl_msg *msg,
ret = auth_proto_rx_authenticate(netdev->ap, frame, frame_len);
+ /*
+ * Allows station to persist settings so it does not retry
+ * the higher order ECC group again
+ */
+ if (status_code ==
+ MMPDU_STATUS_CODE_UNSUPP_FINITE_CYCLIC_GROUP &&
+ netdev->event_filter)
+ netdev->event_filter(netdev,
+ NETDEV_EVENT_ECC_GROUP_RETRY,
+ NULL, netdev->user_data);
+
/* We have sent another CMD_AUTHENTICATE / CMD_ASSOCIATE */
if (ret == 0 || ret == -EAGAIN)
return;
diff --git a/src/netdev.h b/src/netdev.h
index d87f09f4..671d0d40 100644
--- a/src/netdev.h
+++ b/src/netdev.h
@@ -51,6 +51,7 @@ enum netdev_event {
NETDEV_EVENT_RSSI_LEVEL_NOTIFY,
NETDEV_EVENT_PACKET_LOSS_NOTIFY,
NETDEV_EVENT_BEACON_LOSS_NOTIFY,
+ NETDEV_EVENT_ECC_GROUP_RETRY,
};
enum netdev_watch_event {
diff --git a/src/station.c b/src/station.c
index 3712d5bb..77d4a547 100644
--- a/src/station.c
+++ b/src/station.c
@@ -3456,6 +3456,18 @@ static void station_event_roaming(struct station *station)
station_enter_state(station, STATION_STATE_FW_ROAMING);
}
+static void station_ecc_group_retry(struct station *station)
+{
+ struct network *network = station_get_connected_network(station);
+
+ if (L_WARN_ON(!network))
+ return;
+
+ station_debug_event(station, "ecc-group-rejected");
+
+ network_set_force_default_ecc_group(network);
+}
+
static void station_netdev_event(struct netdev *netdev, enum netdev_event event,
void *event_data, void *user_data)
{
@@ -3497,6 +3509,9 @@ static void station_netdev_event(struct netdev *netdev, enum netdev_event event,
case NETDEV_EVENT_BEACON_LOSS_NOTIFY:
station_beacon_lost(station);
break;
+ case NETDEV_EVENT_ECC_GROUP_RETRY:
+ station_ecc_group_retry(station);
+ break;
}
}
--
2.34.1
next prev parent reply other threads:[~2024-02-27 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 18:33 [PATCH 01/11] doc: Document UseDefaultEccGroup James Prestwood
2024-02-27 18:33 ` [PATCH 02/11] knownnetworks: add option to force a default ECC group James Prestwood
2024-02-27 18:33 ` [PATCH 03/11] network: retain default ECC group for OWE after setting James Prestwood
2024-02-27 18:33 ` [PATCH 04/11] network: set use default ECC group in handshake setup James Prestwood
2024-02-27 18:33 ` [PATCH 05/11] sae: remove sae_sm_set_force_group_19, use handshake James Prestwood
2024-02-27 18:34 ` James Prestwood [this message]
2024-02-27 18:34 ` [PATCH 07/11] auto-t: add Device.event_ocurred James Prestwood
2024-02-27 18:34 ` [PATCH 08/11] auto-t: add HostapdCLI.sta_status James Prestwood
2024-02-27 18:34 ` [PATCH 09/11] auto-t: refactor/fix testSAE James Prestwood
2024-02-27 18:34 ` [PATCH 10/11] auto-t: Add test for new SAE default group behavior James Prestwood
2024-02-27 18:34 ` [PATCH 11/11] auto-t: add OWE test for auto default group James Prestwood
2024-02-27 19:56 ` [PATCH 01/11] doc: Document UseDefaultEccGroup Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240227183405.257206-6-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox