From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 2/4] eap-mschapv2: Check Password-Hash exists when loading settings
Date: Fri, 1 Mar 2024 11:40:54 -0800 [thread overview]
Message-ID: <20240301194056.1665549-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20240301194056.1665549-1-prestwoj@gmail.com>
Caught by static analysis, the Password-Hash was never validated so
it could end up memcpying from a NULL pointer.
---
src/eap-mschapv2.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/eap-mschapv2.c b/src/eap-mschapv2.c
index ef0ce620..7f71cc82 100644
--- a/src/eap-mschapv2.c
+++ b/src/eap-mschapv2.c
@@ -532,6 +532,9 @@ static bool eap_mschapv2_load_settings(struct eap_state *eap,
snprintf(setting, sizeof(setting), "%sPassword-Hash", prefix);
hash = l_settings_get_bytes(settings, "Security", setting,
&hash_len);
+ if (!hash)
+ goto error;
+
memcpy(state->password_hash, hash, 16);
explicit_bzero(hash, 16);
l_free(hash);
--
2.34.1
next prev parent reply other threads:[~2024-03-01 19:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-01 19:40 [PATCH 1/4] p2p: check connected peer before processing request James Prestwood
2024-03-01 19:40 ` James Prestwood [this message]
2024-03-01 19:40 ` [PATCH 3/4] monitor: properly mask HE capabilities bitfield James Prestwood
2024-03-01 19:40 ` [PATCH 4/4] client: fix two issues caught by static analysis James Prestwood
2024-03-12 3:10 ` [PATCH 1/4] p2p: check connected peer before processing request Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301194056.1665549-2-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox