From: John Brandt <brandtwjohn@gmail.com>
To: iwd@lists.linux.dev
Cc: John Brandt <brandtwjohn@gmail.com>
Subject: [PATCH 03/11] sae: add function sae_set_group
Date: Sun, 21 Apr 2024 05:50:33 -0700 [thread overview]
Message-ID: <20240421125050.6649-4-brandtwjohn@gmail.com> (raw)
In-Reply-To: <20240421125050.6649-1-brandtwjohn@gmail.com>
Refactor code by adding function sae_set_group. This will make the next
commits easier where basic SAE support for APs is added.
---
src/sae.c | 23 ++++++++++++-----------
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/src/sae.c b/src/sae.c
index bf9fb0ff..c133386f 100644
--- a/src/sae.c
+++ b/src/sae.c
@@ -148,6 +148,16 @@ static void sae_reset_state(struct sae_sm *sm)
sm->pwe = NULL;
}
+static int sae_set_group(struct sae_sm *sm, int group)
+{
+ sae_debug("Using group %u", group);
+
+ sm->group = group;
+ sm->curve = l_ecc_curve_from_ike_group(group);
+
+ return 0;
+}
+
static int sae_choose_next_group(struct sae_sm *sm)
{
const unsigned int *ecc_groups = l_ecc_supported_ike_groups();
@@ -166,9 +176,7 @@ static int sae_choose_next_group(struct sae_sm *sm)
sae_debug("Forcing default SAE group 19");
sm->group_retry++;
- sm->group = 19;
-
- goto get_curve;
+ return sae_set_group(sm, 19);
}
do {
@@ -182,14 +190,7 @@ static int sae_choose_next_group(struct sae_sm *sm)
if (reset)
sae_reset_state(sm);
- sm->group = ecc_groups[sm->group_retry];
-
-get_curve:
- sae_debug("Using group %u", sm->group);
-
- sm->curve = l_ecc_curve_from_ike_group(sm->group);
-
- return 0;
+ return sae_set_group(sm, ecc_groups[sm->group_retry]);
}
static int sae_valid_group(struct sae_sm *sm, unsigned int group)
--
2.44.0
next prev parent reply other threads:[~2024-04-21 12:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-21 12:50 [PATCH 00/11] Basic SAE support for AP mode John Brandt
2024-04-21 12:50 ` [PATCH 01/11] ap: ability to advertise PSK and SAE John Brandt
2024-04-21 12:50 ` [PATCH 02/11] ap: accept PSK/SAE in auth depending on config John Brandt
2024-04-24 12:05 ` James Prestwood
2024-04-21 12:50 ` John Brandt [this message]
2024-04-24 12:05 ` [PATCH 03/11] sae: add function sae_set_group James Prestwood
2024-04-21 12:50 ` [PATCH 04/11] sae: refactor and add function sae_calculate_keys John Brandt
2024-04-24 12:06 ` James Prestwood
2024-04-21 12:50 ` [PATCH 05/11] sae: make sae_process_commit callable in AP mode John Brandt
2024-04-24 12:08 ` James Prestwood
2024-04-21 12:50 ` [PATCH 06/11] sae: verify offered group " John Brandt
2024-04-21 12:50 ` [PATCH 07/11] sae: support reception of Confirm frame by AP John Brandt
2024-04-24 12:08 ` James Prestwood
2024-04-21 12:50 ` [PATCH 08/11] ap: add support to handle SAE authentication John Brandt
2024-04-24 12:06 ` James Prestwood
2024-04-21 12:50 ` [PATCH 09/11] ap: enable start of 4-way HS after SAE John Brandt
2024-04-21 12:50 ` [PATCH 10/11] eapol: support PTK derivation with SHA256 John Brandt
2024-04-21 12:50 ` [PATCH 11/11] eapol: encrypt key data for AKM-defined ciphers John Brandt
2024-04-22 13:52 ` [PATCH 00/11] Basic SAE support for AP mode James Prestwood
2024-04-24 12:07 ` James Prestwood
2024-04-29 0:04 ` John Brandt
2024-04-29 12:00 ` James Prestwood
2024-04-30 23:27 ` KeithG
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240421125050.6649-4-brandtwjohn@gmail.com \
--to=brandtwjohn@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox