From: John Brandt <brandtwjohn@gmail.com>
To: iwd@lists.linux.dev
Cc: John Brandt <brandtwjohn@gmail.com>
Subject: [PATCH v2 01/18] ap: ability to advertise PSK and SAE
Date: Sun, 5 May 2024 17:30:24 -0700 [thread overview]
Message-ID: <20240506003518.320176-2-brandtwjohn@gmail.com> (raw)
In-Reply-To: <20240506003518.320176-1-brandtwjohn@gmail.com>
Add the configuration option AKMSuites under Security so it becomes
possible to support both PSK and SAE. This influences the advertised
AKMs in the beacon.
---
src/ap.c | 26 +++++++++++++++++++++++++-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/src/ap.c b/src/ap.c
index b4e7593e..d50f9e4f 100644
--- a/src/ap.c
+++ b/src/ap.c
@@ -80,6 +80,7 @@ struct ap_state {
unsigned int ciphers;
enum ie_rsn_cipher_suite group_cipher;
+ unsigned int akm_suites;
uint32_t beacon_interval;
struct l_uintset *rates;
uint32_t start_stop_cmd_id;
@@ -631,7 +632,7 @@ static void ap_drop_rsna(struct sta_state *sta)
static void ap_set_rsn_info(struct ap_state *ap, struct ie_rsn_info *rsn)
{
memset(rsn, 0, sizeof(*rsn));
- rsn->akm_suites = IE_RSN_AKM_SUITE_PSK;
+ rsn->akm_suites = ap->akm_suites;
rsn->pairwise_ciphers = ap->ciphers;
rsn->group_cipher = ap->group_cipher;
}
@@ -3620,6 +3621,7 @@ static int ap_load_config(struct ap_state *ap, const struct l_settings *config,
size_t len;
L_AUTO_FREE_VAR(char *, strval) = NULL;
_auto_(l_strv_free) char **ciphers_str = NULL;
+ _auto_(l_strv_free) char **akms_str = NULL;
uint16_t cipher_mask;
int err;
int i;
@@ -3838,6 +3840,28 @@ static int ap_load_config(struct ap_state *ap, const struct l_settings *config,
ap->ciphers |= cipher;
}
+ akms_str = l_settings_get_string_list(config, "Security",
+ "AKMSuites", ',');
+ for (i = 0; akms_str && akms_str[i]; i++) {
+ if (!strcmp(akms_str[i], "PSK"))
+ ap->akm_suites |= IE_RSN_AKM_SUITE_PSK;
+ else if (!strcmp(akms_str[i], "SAE"))
+ ap->akm_suites |= IE_RSN_AKM_SUITE_SAE_SHA256;
+ else {
+ l_warn("Unsupported or unknown AKM suite %s",
+ akms_str[i]);
+ return -ENOTSUP;
+ }
+ }
+
+ if (ap->akm_suites == 0) {
+ /*
+ * Default behavior if no AKMs are specified but a passphrase
+ * is to only enable PSK == WPA2.
+ */
+ ap->akm_suites |= IE_RSN_AKM_SUITE_PSK;
+ }
+
if (!ap->ciphers) {
/*
* Default behavior if no ciphers are specified, disable TKIP
--
2.45.0
next prev parent reply other threads:[~2024-05-06 0:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 0:30 [PATCH v2 00/18] Basic WPA3 support in AP mode John Brandt
2024-05-06 0:30 ` John Brandt [this message]
2024-05-06 0:30 ` [PATCH v2 02/18] ap: accept PSK/SAE in auth depending on config John Brandt
2024-05-07 15:07 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 03/18] unit: fix SAE unit tests John Brandt
2024-05-07 15:51 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 04/18] sae: add function sae_set_group John Brandt
2024-05-07 14:53 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 05/18] sae: refactor and add function sae_calculate_keys John Brandt
2024-05-07 15:13 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 06/18] sae: make sae_process_commit callable in AP mode John Brandt
2024-05-06 0:30 ` [PATCH v2 07/18] sae: verify offered group " John Brandt
2024-05-07 15:11 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 08/18] sae: support reception of Confirm frame by AP John Brandt
2024-05-07 15:51 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 09/18] ap: add support to handle SAE authentication John Brandt
2024-05-07 15:44 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 10/18] ap: enable start of 4-way HS after SAE John Brandt
2024-05-06 0:30 ` [PATCH v2 11/18] eapol: support PTK derivation with SHA256 John Brandt
2024-05-07 15:52 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 12/18] eapol: encrypt key data for AKM-defined ciphers John Brandt
2024-05-07 16:04 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 13/18] unit: add unit test for SAE AP mode John Brandt
2024-05-06 0:30 ` [PATCH v2 14/18] ap: move toward requiring MFP when using SAE John Brandt
2024-05-07 16:12 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 15/18] handshake: add functions to save and set IGTK John Brandt
2024-05-07 16:20 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 16/18] eapol: include IGTK in 4-way handshake as AP John Brandt
2024-05-07 16:20 ` Denis Kenzior
2024-05-06 0:30 ` [PATCH v2 17/18] ap: generate IGTK on startup if MFP is enabled John Brandt
2024-05-06 0:30 ` [PATCH v2 18/18] ap: propogate IGTK and RSC to handshake John Brandt
2024-05-07 16:23 ` [PATCH v2 00/18] Basic WPA3 support in AP mode Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240506003518.320176-2-brandtwjohn@gmail.com \
--to=brandtwjohn@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox