From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH v2 02/11] netdev: add NETDEV_RESULT_DISCONNECTED
Date: Thu, 18 Jul 2024 04:45:05 -0700 [thread overview]
Message-ID: <20240718114514.2916258-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20240718114514.2916258-1-prestwoj@gmail.com>
This new result is meant to handle cases where a disconnect
event (deauth/disassoc) was received during an ongoing connection.
Whether that's during authentication, association, the 4-way
handshake, or key setting.
---
src/netdev.h | 2 ++
src/p2p.c | 1 +
src/station.c | 1 +
3 files changed, 4 insertions(+)
diff --git a/src/netdev.h b/src/netdev.h
index 671d0d40..db0440d0 100644
--- a/src/netdev.h
+++ b/src/netdev.h
@@ -36,6 +36,7 @@ enum netdev_result {
NETDEV_RESULT_HANDSHAKE_FAILED,
NETDEV_RESULT_KEY_SETTING_FAILED,
NETDEV_RESULT_ABORTED,
+ NETDEV_RESULT_DISCONNECTED,
};
enum netdev_event {
@@ -86,6 +87,7 @@ typedef void (*netdev_command_cb_t)(struct netdev *netdev, int result,
* NETDEV_RESULT_HANDSHAKE_FAILED - MMPDU_REASON_CODE
* NETDEV_RESULT_KEY_SETTING_FAILED - unused
* NETDEV_RESULT_ABORTED - unused.
+ * NETDEV_RESULT_DISCONNECTED - MMPDU_REASON_CODE
*/
typedef void (*netdev_connect_cb_t)(struct netdev *netdev,
enum netdev_result result,
diff --git a/src/p2p.c b/src/p2p.c
index 205d4fcb..e8c7c5de 100644
--- a/src/p2p.c
+++ b/src/p2p.c
@@ -1366,6 +1366,7 @@ static void p2p_netdev_connect_cb(struct netdev *netdev,
case NETDEV_RESULT_ASSOCIATION_FAILED:
case NETDEV_RESULT_HANDSHAKE_FAILED:
case NETDEV_RESULT_KEY_SETTING_FAILED:
+ case NETDEV_RESULT_DISCONNECTED:
/*
* In the AUTHENTICATION_FAILED and ASSOCIATION_FAILED
* cases there's nothing to disconnect. In the
diff --git a/src/station.c b/src/station.c
index 3ead4326..01f6b78e 100644
--- a/src/station.c
+++ b/src/station.c
@@ -3319,6 +3319,7 @@ static void station_connect_cb(struct netdev *netdev, enum netdev_result result,
blacklist_remove_bss(station->connected_bss->addr);
station_connect_ok(station);
return;
+ case NETDEV_RESULT_DISCONNECTED:
case NETDEV_RESULT_HANDSHAKE_FAILED:
/* reason code in this case */
if (station_retry_with_reason(station, l_get_u16(event_data)))
--
2.34.1
next prev parent reply other threads:[~2024-07-18 11:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 11:45 [PATCH v2 00/11] Refactor to unify connect failure code path James Prestwood
2024-07-18 11:45 ` [PATCH v2 01/11] station: print unknown channel number in neighbor report James Prestwood
2024-07-18 11:45 ` James Prestwood [this message]
2024-07-18 11:45 ` [PATCH v2 03/11] station: handle NETDEV_RESULT_DISCONNECTED James Prestwood
2024-07-18 11:45 ` [PATCH v2 04/11] station: update logic for handshake failure James Prestwood
2024-07-18 11:45 ` [PATCH v2 05/11] netdev: handle disconnect event during a connection James Prestwood
2024-07-18 11:45 ` [PATCH v2 06/11] eapol: move HANDSHAKE_STARTED_EVENT to eapol_start() James Prestwood
2024-07-18 11:45 ` [PATCH v2 07/11] station: add handshake-started debug event James Prestwood
2024-07-18 11:45 ` [PATCH v2 08/11] auto-t: add clear_events() to IWD class James Prestwood
2024-07-18 11:45 ` [PATCH v2 09/11] auto-t: add reason/test arguments to hostapd deauthenticate James Prestwood
2024-07-18 11:45 ` [PATCH v2 10/11] auto-t: Add deauth during the 4-way handshake test James Prestwood
2024-07-18 11:45 ` [PATCH v2 11/11] auto-t: a few random autotest fixes James Prestwood
2024-07-18 21:11 ` [PATCH v2 00/11] Refactor to unify connect failure code path Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240718114514.2916258-3-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox