From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH] monitor: fix the CQM RSSI threshold attribute
Date: Fri, 26 Jul 2024 05:18:08 -0700 [thread overview]
Message-ID: <20240726121808.1629079-1-prestwoj@gmail.com> (raw)
This attribute is actually an array of signed 32 bit integers and it
was being treated as a single integer. This would work until more
than one threshold was set, then it would fail to parse it.
---
monitor/nlmon.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/monitor/nlmon.c b/monitor/nlmon.c
index a900f7cc..e5cd5451 100644
--- a/monitor/nlmon.c
+++ b/monitor/nlmon.c
@@ -5618,8 +5618,26 @@ static void print_cqm_event(unsigned int level, const char *label,
}
}
+static void print_cqm_thresholds(unsigned int level, const char *label,
+ const void *data, uint16_t size)
+{
+ const int32_t *thresholds = data;
+ unsigned int i;
+
+ if (size % 4) {
+ printf("malformed packet");
+ return;
+ }
+
+ print_attr(level, "%s:", label);
+
+ for (i = 0; i < size / 4; i++)
+ print_attr(level + 1, "Threshold: %d", thresholds[i]);
+
+}
static const struct attr_entry cqm_table[] = {
- { NL80211_ATTR_CQM_RSSI_THOLD, "RSSI threshold", ATTR_U32 },
+ { NL80211_ATTR_CQM_RSSI_THOLD, "RSSI thresholds", ATTR_CUSTOM,
+ { .function = print_cqm_thresholds } },
{ NL80211_ATTR_CQM_RSSI_HYST, "RSSI hysteresis", ATTR_U32 },
{ NL80211_ATTR_CQM_RSSI_THRESHOLD_EVENT,
"RSSI threshold event", ATTR_CUSTOM,
--
2.34.1
next reply other threads:[~2024-07-26 12:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-26 12:18 James Prestwood [this message]
2024-07-26 14:53 ` [PATCH] monitor: fix the CQM RSSI threshold attribute Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240726121808.1629079-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox