public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 5/7] netdev: Create owe_sm for fullmac connections
Date: Mon,  5 Aug 2024 09:07:12 -0500	[thread overview]
Message-ID: <20240805140721.57518-5-denkenz@gmail.com> (raw)
In-Reply-To: <20240805140721.57518-1-denkenz@gmail.com>

Somehow this ability was lost in the refactoring.  OWE was intended to
be used on fullmac cards, but the state machine is only actually created
if the connection type ends up being softmac.

Fixes: 8b6ad5d3b9ec ("owe: netdev: refactor to remove OWE as an auth-proto")
---
 src/netdev.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/netdev.c b/src/netdev.c
index e27a0019b7ea..50e60c5d0c98 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -3826,6 +3826,12 @@ static void netdev_connect_common(struct netdev *netdev,
 	if (!is_rsn)
 		goto build_cmd_connect;
 
+	/* For OWE, always use the CMD_CONNECT path */
+	if (IE_AKM_IS_OWE(hs->akm_suite)) {
+		netdev->owe_sm = owe_sm_new(hs);
+		goto build_cmd_connect;
+	}
+
 	if (nhs->type != CONNECTION_TYPE_SOFTMAC)
 		goto build_cmd_connect;
 
@@ -3848,10 +3854,6 @@ static void netdev_connect_common(struct netdev *netdev,
 		}
 
 		break;
-	case IE_RSN_AKM_SUITE_OWE:
-		netdev->owe_sm = owe_sm_new(hs);
-
-		goto build_cmd_connect;
 	case IE_RSN_AKM_SUITE_FILS_SHA256:
 	case IE_RSN_AKM_SUITE_FILS_SHA384:
 	case IE_RSN_AKM_SUITE_FT_OVER_FILS_SHA256:
-- 
2.45.2


  parent reply	other threads:[~2024-08-05 14:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-05 14:07 [PATCH 1/7] monitor: Decode RMNet Mux Identifier Denis Kenzior
2024-08-05 14:07 ` [PATCH 2/7] monitor: Mask flags from attribute identifier Denis Kenzior
2024-08-05 14:07 ` [PATCH 3/7] wiphy: Fix use of wiphy_has_feature Denis Kenzior
2024-08-05 14:07 ` [PATCH 4/7] ie: Add IE_AKM_IS_OWE Denis Kenzior
2024-08-05 14:07 ` Denis Kenzior [this message]
2024-08-05 14:07 ` [PATCH 6/7] fils: Ensure capability checks are consistent Denis Kenzior
2024-08-05 14:07 ` [PATCH 7/7] netdev: Simplify FILS handling in netdev_connect_common Denis Kenzior
2024-08-05 14:21   ` James Prestwood
2024-08-05 14:34     ` Denis Kenzior
2024-08-05 14:21 ` [PATCH 1/7] monitor: Decode RMNet Mux Identifier James Prestwood
2024-08-06 14:33 ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240805140721.57518-5-denkenz@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox