From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.linux.dev
Cc: Denis Kenzior <denkenz@gmail.com>
Subject: [PATCH 6/7] fils: Ensure capability checks are consistent
Date: Mon, 5 Aug 2024 09:07:13 -0500 [thread overview]
Message-ID: <20240805140721.57518-6-denkenz@gmail.com> (raw)
In-Reply-To: <20240805140721.57518-1-denkenz@gmail.com>
iwd supports FILS only on softmac drivers. Ensure the capability check
is consistent between wiphy and netdev, both the softmac and the
relevant EXT_FEATURE bit must be checked.
CMD_EXTERNAL_AUTH could potentially be used for FILS for FullMAC cards,
but no hardware supporting this has been identified yet.
---
src/netdev.c | 3 ++-
src/wiphy.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/netdev.c b/src/netdev.c
index 50e60c5d0c98..fb095fdca561 100644
--- a/src/netdev.c
+++ b/src/netdev.c
@@ -3776,7 +3776,8 @@ static int netdev_handshake_state_setup_connection_type(
case IE_RSN_AKM_SUITE_FT_OVER_FILS_SHA256:
case IE_RSN_AKM_SUITE_FT_OVER_FILS_SHA384:
/* FILS has no offload in any upstream driver */
- if (softmac)
+ if (softmac && wiphy_has_ext_feature(wiphy,
+ NL80211_EXT_FEATURE_FILS_STA))
goto softmac;
return -ENOTSUP;
diff --git a/src/wiphy.c b/src/wiphy.c
index 6b755ff8201d..13d498a5cd0c 100644
--- a/src/wiphy.c
+++ b/src/wiphy.c
@@ -277,6 +277,7 @@ enum ie_rsn_akm_suite wiphy_select_akm(struct wiphy *wiphy,
*/
if (security == SECURITY_8021X) {
if (wiphy_has_ext_feature(wiphy, NL80211_EXT_FEATURE_FILS_STA) &&
+ wiphy->support_cmds_auth_assoc &&
fils_capable_hint) {
if ((info->akm_suites &
IE_RSN_AKM_SUITE_FT_OVER_FILS_SHA384) &&
--
2.45.2
next prev parent reply other threads:[~2024-08-05 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 14:07 [PATCH 1/7] monitor: Decode RMNet Mux Identifier Denis Kenzior
2024-08-05 14:07 ` [PATCH 2/7] monitor: Mask flags from attribute identifier Denis Kenzior
2024-08-05 14:07 ` [PATCH 3/7] wiphy: Fix use of wiphy_has_feature Denis Kenzior
2024-08-05 14:07 ` [PATCH 4/7] ie: Add IE_AKM_IS_OWE Denis Kenzior
2024-08-05 14:07 ` [PATCH 5/7] netdev: Create owe_sm for fullmac connections Denis Kenzior
2024-08-05 14:07 ` Denis Kenzior [this message]
2024-08-05 14:07 ` [PATCH 7/7] netdev: Simplify FILS handling in netdev_connect_common Denis Kenzior
2024-08-05 14:21 ` James Prestwood
2024-08-05 14:34 ` Denis Kenzior
2024-08-05 14:21 ` [PATCH 1/7] monitor: Decode RMNet Mux Identifier James Prestwood
2024-08-06 14:33 ` Denis Kenzior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240805140721.57518-6-denkenz@gmail.com \
--to=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox