public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
* [PATCH 1/2] doc: deprecate UseDefaultInterface in docs
@ 2024-08-27 14:18 James Prestwood
  2024-08-27 14:18 ` [PATCH 2/2] manager: deprecate UseDefaultInterface James Prestwood
  2024-08-28  2:23 ` [PATCH 1/2] doc: deprecate UseDefaultInterface in docs Denis Kenzior
  0 siblings, 2 replies; 3+ messages in thread
From: James Prestwood @ 2024-08-27 14:18 UTC (permalink / raw)
  To: iwd; +Cc: James Prestwood

---
 src/iwd.config.rst | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/iwd.config.rst b/src/iwd.config.rst
index a64e4f9f..448046c6 100644
--- a/src/iwd.config.rst
+++ b/src/iwd.config.rst
@@ -74,7 +74,7 @@ The group ``[General]`` contains general settings.
        ``[Network]`` settings for additional settings related to network
        configuration.
 
-   * - UseDefaultInterface
+   * - UseDefaultInterface (**deprecated**)
      - Values: true, **false**
 
        Do not allow **iwd** to destroy / recreate wireless interfaces at
@@ -84,6 +84,9 @@ The group ``[General]`` contains general settings.
        most users with an upstream driver it should be safe to omit/disable
        this setting.
 
+       This setting is deprecated, please use [DriverQuirks].DefaultInterface
+       instead.
+
    * - AddressRandomization
      - Values: **disabled**, once, network
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] manager: deprecate UseDefaultInterface
  2024-08-27 14:18 [PATCH 1/2] doc: deprecate UseDefaultInterface in docs James Prestwood
@ 2024-08-27 14:18 ` James Prestwood
  2024-08-28  2:23 ` [PATCH 1/2] doc: deprecate UseDefaultInterface in docs Denis Kenzior
  1 sibling, 0 replies; 3+ messages in thread
From: James Prestwood @ 2024-08-27 14:18 UTC (permalink / raw)
  To: iwd; +Cc: James Prestwood

---
 src/manager.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/manager.c b/src/manager.c
index f1aa59c7..5bedfcc5 100644
--- a/src/manager.c
+++ b/src/manager.c
@@ -894,8 +894,11 @@ static int manager_init(void)
 	}
 
 	if (!l_settings_get_bool(config, "General",
-				"UseDefaultInterface", &use_default))
+				"UseDefaultInterface", &use_default)) {
+		l_warn("[General].UseDefaultInterface is deprecated, please "
+			"use [DriverQuirks].DefaultInterface instead");
 		use_default = false;
+	}
 
 	return 0;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] doc: deprecate UseDefaultInterface in docs
  2024-08-27 14:18 [PATCH 1/2] doc: deprecate UseDefaultInterface in docs James Prestwood
  2024-08-27 14:18 ` [PATCH 2/2] manager: deprecate UseDefaultInterface James Prestwood
@ 2024-08-28  2:23 ` Denis Kenzior
  1 sibling, 0 replies; 3+ messages in thread
From: Denis Kenzior @ 2024-08-28  2:23 UTC (permalink / raw)
  To: James Prestwood, iwd

Hi James,

On 8/27/24 9:18 AM, James Prestwood wrote:
> ---
>   src/iwd.config.rst | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 

All applied, thanks.

Regards,
-Denis


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-08-28  2:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-27 14:18 [PATCH 1/2] doc: deprecate UseDefaultInterface in docs James Prestwood
2024-08-27 14:18 ` [PATCH 2/2] manager: deprecate UseDefaultInterface James Prestwood
2024-08-28  2:23 ` [PATCH 1/2] doc: deprecate UseDefaultInterface in docs Denis Kenzior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox