public inbox for iwd@lists.linux.dev
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [PATCH 3/4] dpp: allow PKEX configurators to run without multicast RX support
Date: Tue, 27 Aug 2024 07:21:24 -0700	[thread overview]
Message-ID: <20240827142125.751023-3-prestwoj@gmail.com> (raw)
In-Reply-To: <20240827142125.751023-1-prestwoj@gmail.com>

Since IWD enrollees can send unicast frames, a PKEX configurator could
still run without multicast support. Using this combination basically
allows any driver to utilize DPP/PKEX assuming the MAC address can
be communicated using some out of band mechanism.
---
 src/dpp.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/dpp.c b/src/dpp.c
index 39b66154..dad74efe 100644
--- a/src/dpp.c
+++ b/src/dpp.c
@@ -4574,11 +4574,9 @@ static struct l_dbus_message *dpp_start_pkex_configurator(struct dpp_sm *dpp,
 				dpp->interface != DPP_INTERFACE_UNBOUND)
 		return dbus_error_busy(message);
 
-	if (!dpp->mcast_support) {
-		l_debug("Multicast frame registration not supported, cannot "
-			"start a configurator");
-		return dbus_error_not_supported(message);
-	}
+	if (!dpp->mcast_support)
+		l_debug("Multicast frame registration not supported, only "
+			"enrollees sending uncast will be supported");
 
 	if (!network || !bss)
 		return dbus_error_not_connected(message);
-- 
2.34.1


  parent reply	other threads:[~2024-08-27 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-27 14:21 [PATCH 1/4] dpp: factor out key derivation and starting PKEX into functions James Prestwood
2024-08-27 14:21 ` [PATCH 2/4] dpp: add Address/Frequency as parameters to PKEX enrollees James Prestwood
2024-08-27 14:21 ` James Prestwood [this message]
2024-08-27 14:21 ` [PATCH 4/4] dpp: scale PKEX timeout by the number of frequencies used James Prestwood
2024-08-28  2:25 ` [PATCH 1/4] dpp: factor out key derivation and starting PKEX into functions Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240827142125.751023-3-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox